Skip to content

Fix case-sensitive repoFullName match dropping maintainer-lane detection #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 2 commits into from
Jun 2, 2026
Merged

Fix case-sensitive repoFullName match dropping maintainer-lane detection #225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82bcbc3
Fix case-sensitive repoFullName match dropping maintainer-lane detection
galuis116 Jun 2, 2026
16a85e6
Merge branch 'main' into fix/maintainer-lane-repo-casing
JSONbored Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/signals/engine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1352,16 +1352,16 @@ export function buildRoleContext(args: {
const normalizedLogin = args.login.toLowerCase();
const [owner] = args.repoFullName.split("/");
const authoredAssociations = [
...(args.pullRequests ?? []).filter((pr) => pr.repoFullName === args.repoFullName && sameLogin(pr.authorLogin, args.login)).map((pr) => pr.authorAssociation),
...(args.issues ?? []).filter((issue) => issue.repoFullName === args.repoFullName && sameLogin(issue.authorLogin, args.login)).map((issue) => issue.authorAssociation),
...(args.pullRequests ?? []).filter((pr) => sameRepo(pr.repoFullName, args.repoFullName) && sameLogin(pr.authorLogin, args.login)).map((pr) => pr.authorAssociation),
...(args.issues ?? []).filter((issue) => sameRepo(issue.repoFullName, args.repoFullName) && sameLogin(issue.authorLogin, args.login)).map((issue) => issue.authorAssociation),
].filter(Boolean) as string[];
const officialRepo = args.profile?.gittensor?.repositories.find((repo) => repo.repoFullName.toLowerCase() === args.repoFullName.toLowerCase());
const touchedByOfficial = Boolean(officialRepo && officialRepo.pullRequests + officialRepo.openIssues + officialRepo.closedIssues > 0);
const touchedByCache = Boolean(
args.profile?.registeredRepoActivity.reposTouched.some((repo) => repo.toLowerCase() === args.repoFullName.toLowerCase()) ||
(args.pullRequests ?? []).some((pr) => pr.repoFullName === args.repoFullName && sameLogin(pr.authorLogin, args.login)) ||
(args.pullRequests ?? []).some((pr) => sameRepo(pr.repoFullName, args.repoFullName) && sameLogin(pr.authorLogin, args.login)) ||
/* v8 ignore next -- Issue-authored cache fallback is defensive; PR and official contribution paths cover role detection behavior. */
(args.issues ?? []).some((issue) => issue.repoFullName === args.repoFullName && sameLogin(issue.authorLogin, args.login)),
(args.issues ?? []).some((issue) => sameRepo(issue.repoFullName, args.repoFullName) && sameLogin(issue.authorLogin, args.login)),
);

let role: ContributorRole = "unknown";
Expand Down
10 changes: 10 additions & 0 deletions test/unit/signals-v2.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -935,6 +935,16 @@ describe("v2 signal builders", () => {
source: "unknown",
normalContributorEvidenceAllowed: true,
});
// Maintainer association must survive a repoFullName casing mismatch between the
// canonical name (e.g. the official source's "Org/Project") and the cached PR's
// "org/project". Case-sensitive matching here would drop the association and
// wrongly mark the maintainer's repo as outside-contributor evidence.
expect(buildRoleContext({ login: "dev", repo: null, repoFullName: "Org/Project", pullRequests: [memberPr], issues: [] })).toMatchObject({
role: "org_member",
maintainerLane: true,
source: "github_association",
association: "MEMBER",
});
});

it("branches repo fit recommendations across pursue, avoid, cleanup, unknown, and maintainer lanes", () => {
Expand Down