feat(selfhost): cache stable GitHub GET reads - #1842
Conversation
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-06-30 08:33:35 UTC
⏸️ Suggested Action - Manual Review
Review summary Nits — 8 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
d1983c4 to
ec98436
Compare
Cache safe GitHub REST GETs through one auth-aware response cache used by Octokit and raw backfill reads. Add per-endpoint TTL overrides, single-flight cold misses, Prometheus counters, and self-host dashboard/docs coverage.
ec98436 to
268455a
Compare
JSONbored
left a comment
There was a problem hiding this comment.
Excellent, much-needed improvements. Approving.
Closes #1839
Summary
What changed
src/github/client.ts, including auth/header cache keys, replay headers, cache metrics, and rate-limit-safe replay behavior.githubJsonWithHeadersthrough the sharedtimeoutFetchpath and skipped rate-limit observation writes for cache replays.Why
Validation
npm run test:cinpm audit --audit-level=moderateNotes