Skip to content

fix(labels): ensurePullRequestLabel misses labels beyond first page #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
glorysr1209-png wants to merge 10 commits into from
Closed

fix(labels): ensurePullRequestLabel misses labels beyond first page #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ddfbb83
fix(labels): look up repository labels by name
glorysr1209-png May 29, 2026
e4b7dba
Merge branch 'main' into fix/pr-label-direct-lookup
JSONbored May 31, 2026
6c9f579
Merge branch 'main' into fix/pr-label-direct-lookup
JSONbored Jun 1, 2026
0fd544b
Merge branch 'main' into fix/pr-label-direct-lookup
JSONbored Jun 1, 2026
03d9ccc
Merge branch 'main' into fix/pr-label-direct-lookup
JSONbored Jun 1, 2026
2aa8441
Merge branch 'main' into fix/pr-label-direct-lookup
JSONbored Jun 1, 2026
83bd6e1
Merge branch 'main' into fix/pr-label-direct-lookup
JSONbored Jun 1, 2026
6757458
Merge branch 'main' into fix/pr-label-direct-lookup
JSONbored Jun 1, 2026
0ba2a2c
Merge branch 'main' into fix/pr-label-direct-lookup
JSONbored Jun 2, 2026
5b8f5b8
Merge branch 'main' into fix/pr-label-direct-lookup
JSONbored Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/github/labels.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,15 @@ export async function ensurePullRequestLabel(

let created = false;
if (options.createMissingLabel) {
const repoLabels = await octokit.request("GET /repos/{owner}/{repo}/labels", {
const labelLookup = await octokit.request("GET /repos/{owner}/{repo}/labels/{name}", {
owner,
repo,
per_page: 100,
name: labelName,
}).catch((error: { status?: number }) => {
if (error.status === 404) return null;
throw error;
});
const labelExists = (repoLabels.data as GitHubLabel[]).some((label) => label.name?.toLowerCase() === labelName.toLowerCase());
if (!labelExists) {
if (!labelLookup) {
await octokit.request("POST /repos/{owner}/{repo}/labels", {
owner,
repo,
Expand Down
4 changes: 2 additions & 2 deletions test/unit/github-labels.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ describe("GitHub PR labels", () => {
calls.push(`${method} ${url}`);
if (url.includes("/access_tokens")) return Response.json({ token: "installation-token" });
if (url.includes("/issues/4/labels") && method === "GET") return Response.json([]);
if (url.includes("/repos/JSONbored/gittensory/labels") && method === "GET") return Response.json([{ name: "gittensor" }]);
if (url.includes("/labels/gittensor") && method === "GET") return Response.json({ name: "gittensor" });
if (url.includes("/issues/4/labels") && method === "POST") return Response.json([{ name: "gittensor" }]);
return new Response("unexpected", { status: 500 });
});
Expand All @@ -59,7 +59,7 @@ describe("GitHub PR labels", () => {
calls.push(`${method} ${url}`);
if (url.includes("/access_tokens")) return Response.json({ token: "installation-token" });
if (url.includes("/issues/4/labels") && method === "GET") return Response.json([]);
if (url.includes("/repos/JSONbored/gittensory/labels") && method === "GET") return Response.json([]);
if (url.includes("/labels/gittensor") && method === "GET") return new Response("not found", { status: 404 });
if (url.includes("/repos/JSONbored/gittensory/labels") && method === "POST") {
const body = JSON.parse(String(init?.body ?? "{}")) as { name?: string; color?: string };
expect(body).toMatchObject({ name: "gittensor", color: "7ee787" });
Expand Down
Loading