fix(orb): surface dropped relay events + correct the stale MCP-501 self-host doc - #1481
Merged
Conversation
…lf-host doc Two small correctness/observability fixes: - The relay retry queue silently dropped events after the 1-hour TTL / 5-attempt budget (e.g. a container down >1h). retryFailedRelays now emits an alertable orb_relay_events_dropped log with the lost-event count so the loss leaves a trace. - docs/self-hosting.md claimed the /mcp server 'returns 501' on self-host. The native Node MCP transport shipped (#980) and /mcp is fully wired, so drop the stale entry from the 'not on self-host' list.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1481 +/- ##
=======================================
Coverage 95.44% 95.44%
=======================================
Files 194 194
Lines 21070 21072 +2
Branches 7624 7625 +1
=======================================
+ Hits 20110 20112 +2
Misses 383 383
Partials 577 577
🚀 New features to boost your workflow:
|
JSONbored
added
the
gittensor:bug
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small correctness/observability fixes (roadmap #5):
retryFailedRelaysnow emits an alertableorb_relay_events_droppedlog with the lost-event count, so the loss leaves a trace./mcpserver as 'returns 501' on self-host — but the native Node MCP transport shipped (Docker image + docker-compose (one-command self-host) #980) and/mcpis fully wired (verified:app.all('/mcp', handleMcpRequest)→WebStandardStreamableHTTPServerTransport). Removed the stale entry.Validation
npm run typecheck;npm run test:coverage— full suite green, 100% changed lines + branches (a console.warn spy asserts the drop log; the no-prune path is covered by the existing empty/increment tests).