feat(signals): recognize deno.lock, bun.lock, pubspec.lock, and Podfile.lock - #1458
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1458 +/- ##
=======================================
Coverage 95.38% 95.38%
=======================================
Files 201 201
Lines 21598 21598
Branches 7807 7807
=======================================
Hits 20601 20601
Misses 416 416
Partials 581 581
🚀 New features to boost your workflow:
|
…le.lock Extend slop path-matchers so additional ecosystem lockfiles classify as lockfile instead of other. Co-authored-by: Cursor <cursoragent@cursor.com>
76394ba to
d3481ad
Compare
|
Caution 🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥 🛑 Gittensory review — closed
🛑 Closed — Readiness score is below the configured threshold — Address the short explicit PR panel actions, then re-run the gate. Review summary Why this is blocked
Nits — 2 non-blocking
Review context
Contributor next steps
Signal definitions
Review detailsGenerated from public PR metadata and the diff. Advisory only; deterministic signals remain authoritative. This change extends the existing basename-normalized lockfile classifier with four more lockfile names and adds direct coverage through both `isLockfile` and `classifyChangedFile`. The implementation is correct because `basename()` already lowercases paths, so `Podfile.lock` and nested paths are handled by the added lowercase `podfile.lock` entry. The tests exercise the intended classification path and do not introduce fabricated coverage. Nits (2)
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Summary
bun.lock,deno.lock,pubspec.lock, andpodfile.lockto slopLOCKFILE_NAMESso they classify aslockfileinstead ofother.Test plan
npx vitest run test/unit/path-matchers.test.tsisLockfileandclassifyChangedFilecases for each new lockfile name