Skip to content

feat(signals): recognize deno.lock, bun.lock, pubspec.lock, and Podfile.lock - #1458

Merged
JSONbored merged 1 commit into
JSONbored:mainfrom
kiannidev:feat/signals-lockfile-names
Jun 28, 2026
Merged

feat(signals): recognize deno.lock, bun.lock, pubspec.lock, and Podfile.lock#1458
JSONbored merged 1 commit into
JSONbored:mainfrom
kiannidev:feat/signals-lockfile-names

Conversation

@kiannidev

@kiannidev kiannidev commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Summary

Test plan

  • npx vitest run test/unit/path-matchers.test.ts
  • isLockfile and classifyChangedFile cases for each new lockfile name

@kiannidev
kiannidev requested a review from JSONbored as a code owner June 26, 2026 10:24
@dosubot dosubot Bot added the size:XS label Jun 26, 2026
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.38%. Comparing base (9e1c351) to head (d3481ad).
⚠️ Report is 101 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1458   +/-   ##
=======================================
  Coverage   95.38%   95.38%           
=======================================
  Files         201      201           
  Lines       21598    21598           
  Branches     7807     7807           
=======================================
  Hits        20601    20601           
  Misses        416      416           
  Partials      581      581           
Files with missing lines Coverage Δ
src/signals/path-matchers.ts 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JSONbored JSONbored added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jun 26, 2026
…le.lock

Extend slop path-matchers so additional ecosystem lockfiles classify as lockfile instead of other.

Co-authored-by: Cursor <cursoragent@cursor.com>
@kiannidev
kiannidev force-pushed the feat/signals-lockfile-names branch from 76394ba to d3481ad Compare June 26, 2026 22:20
@loopover-orb

loopover-orb Bot commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Caution

🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥

🛑 Gittensory review — closed

2 files · 1 AI reviewers · 1 blocker · readiness 73/100 · CI green · unknown

🛑 Closed — Readiness score is below the configured threshold — Address the short explicit PR panel actions, then re-run the gate.

Review summary
This change extends the existing basename-normalized lockfile classifier with four more lockfile names and adds direct coverage through both `isLockfile` and `classifyChangedFile`. The implementation is correct because `basename()` already lowercases paths, so `Podfile.lock` and nested paths are handled by the added lowercase `podfile.lock` entry. The tests exercise the intended classification path and do not introduce fabricated coverage.

Why this is blocked

  • Readiness score is below the configured threshold — Address the short explicit PR panel actions, then re-run the gate.
Signal Result Evidence
Code review ❌ 1 blocker 1 reviewers, synthesized
Linked issue ✅ Linked #1422
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Review load ✅ 20/20 Readiness component derived from cached public PR metadata and labels; size label size:XS.
Validation evidence ❌ 5/25 Cached preflight status is hold.
Open PR queue ❌ 3/10 24 open PR(s), 14 likely reviewable, 10 unlinked.
Contributor context ✅ Confirmed Gittensor contributor kiannidev; Gittensor profile; 3213 PR(s), 48 issue(s).
Gate result ❌ Blocking Repo-configured hard blocker found.
Nits — 2 non-blocking
  • nit: test/unit/path-matchers.test.ts:63 only exercises mixed-case handling for `Podfile.lock`; add one mixed-case or nested example for another newly added lockfile if you want the test name's full 'regardless of directory or case' contract to stay explicit.
  • test/unit/path-matchers.test.ts:63 could include `apps/API/deno.lock` or `Mobile/Pubspec.lock` to make the new entries visibly covered by the same basename/case normalization behavior as the older lockfiles.
Review context
  • Author: kiannidev
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: not available
  • Official Gittensor activity: 3213 PR(s), 48 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Fix blocker.
  • Expect slower review.
  • Refresh registry data or choose a registered active repo.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Review load = cached public PR metadata such as size labels, changed paths, and preflight status.
  • Open PR queue = repo-wide review pressure; it is not a PR quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
Review details

Generated from public PR metadata and the diff. Advisory only; deterministic signals remain authoritative.

This change extends the existing basename-normalized lockfile classifier with four more lockfile names and adds direct coverage through both `isLockfile` and `classifyChangedFile`. The implementation is correct because `basename()` already lowercases paths, so `Podfile.lock` and nested paths are handled by the added lowercase `podfile.lock` entry. The tests exercise the intended classification path and do not introduce fabricated coverage.

Nits (2)

  • nit: test/unit/path-matchers.test.ts:63 only exercises mixed-case handling for `Podfile.lock`; add one mixed-case or nested example for another newly added lockfile if you want the test name's full 'regardless of directory or case' contract to stay explicit.
  • test/unit/path-matchers.test.ts:63 could include `apps/API/deno.lock` or `Mobile/Pubspec.lock` to make the new entries visibly covered by the same basename/case normalization behavior as the older lockfiles.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@loopover-orb loopover-orb Bot added gittensor gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. and removed gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. labels Jun 27, 2026
@JSONbored JSONbored added gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. and removed gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. labels Jun 27, 2026
@loopover-orb loopover-orb Bot added gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. and removed gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. labels Jun 27, 2026
@JSONbored JSONbored added gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. and removed gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. labels Jun 28, 2026
@dosubot dosubot Bot added the lgtm label Jun 28, 2026
@JSONbored
JSONbored merged commit d54369f into JSONbored:main Jun 28, 2026
15 of 16 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in gittensory - v1 roadmap Jun 28, 2026
@loopover-orb loopover-orb Bot added gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. and removed gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. labels Jun 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants