feat(convergence): unified PR review comment — reviewbot renderer ported + wired (default-OFF) - #1007
Conversation
…n runbook Native, logic-faithful port of reviewbot's unified PR-comment renderer into gittensory as a self-contained module: src/review/unified-comment.ts (renderUnifiedReviewComment + buildUnifiedReviewInput + deriveUnifiedStatus + extractReviewSummary + inlined minimal types; ZERO reviewbot imports). Only one mechanical strict-flag guard (exactOptionalPropertyTypes conditional spreads). test/unit/unified-comment.test.ts 20/20 (1:1 with reviewbot). typecheck clean. Part of the reviewbot->gittensory convergence — reviewbot's code becomes gittensory's natively. CONVERGENCE_RUNBOOK.md = the staged A-E plan. LOCAL ONLY (not pushed).
…ehind a default-OFF flag When UNIFIED_REVIEW_COMMENT is truthy AND the gate evaluated, maybePublishPrPublicSurface renders the ONE converged comment (gittensory shape + reviewbot's review folded in) via src/review/unified-comment-bridge.ts buildUnifiedCommentBody, prepending PR_PANEL_COMMENT_MARKER so the existing upsert updates in place. Gate stays authoritative (conclusion -> Verdict -> deriveUnifiedStatus). Flag-OFF (default) keeps the legacy panel byte-identical (only const->let on deterministicBody; signals/engine.ts additive 53/0 via a new buildPublicPrPanelSignalRows helper). 12 bridge tests; typecheck clean. LOCAL ONLY (not pushed).
|
Note Gittensory Gate skippedPR closed before full evaluation. No late first comment was created.
💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers. |
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gittensory-ui | 4917f3c | Commit Preview URL Branch Preview URL |
Jun 22 2026, 09:16 AM |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1007 +/- ##
==========================================
- Coverage 96.61% 96.61% -0.01%
==========================================
Files 110 112 +2
Lines 15079 15269 +190
Branches 5451 5536 +85
==========================================
+ Hits 14569 14752 +183
Misses 106 106
- Partials 404 411 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 🛠️ Maintainer review — Held for maintainer reviewReviewed 11 changed file(s) — two independent AI reviewers, synthesized. 🛠️ Request changes. Address the suggestions below before merging.
Merge readiness: ❌ CI is red — approval withheld until it's green. Failing: see the checks tab. Summary The change introduces a pure unified‑comment renderer and a bridge that maps existing gate and panel data onto it. Types and functions are correctly exported and imported, the flag handling respects existing conventions, and no forbidden public terms are introduced. Security‑related handling (public‑safe redaction, SSRF guards, secret env vars) remains unchanged. The implementation appears functionally correct and maintains backward compatibility when the flag is off. The only current issue is the failing code‑coverage check (codecov/patch), which prevents auto‑merge. 🛑 Concerns raised — review before merging (reviewers were not unanimous)
💡 Nits — non-blocking, optional
|
ghost
left a comment
There was a problem hiding this comment.
Recommend close (ci_red) — held for your decision
ghost
left a comment
There was a problem hiding this comment.
Recommend close (ci_red) — held for your decision
ghost
left a comment
There was a problem hiding this comment.
Recommend close (ci_red) — held for your decision
First convergence milestone (Part of #983 · reviewbot → gittensory).
Natively ports reviewbot's unified PR-review-comment renderer into gittensory (
src/review/unified-comment.ts— self-contained, zero reviewbot imports, strict-compliant) and wires it intomaybePublishPrPublicSurfacebehind a newUNIFIED_REVIEW_COMMENTenv flag (default OFF — fully dormant).When ON, the PR panel becomes the converged comment: gittensory's readiness signals + reviewbot's review folded into ONE in-place comment (same
gittensory-pr-panel:v1marker), with gittensory's gate authoritative. Flag-OFF is byte-identical to today (onlyconst→leton the legacy path;signals/engine.tsadditive 53/0 via a newbuildPublicPrPanelSignalRowshelper).Locally verified: typecheck clean ·
test:unit2329 pass (1 pre-existing unrelatedsignals-v2failure) ·test:workerspass · 12 new bridge tests. Safe to merge dormant.The reviewbot-side
reviewTargetseam landed separately in the reviewbot repo. Closed-PR panel left on legacy (follow-up). The full end-to-end convergence plan is being broken into issues under #983.