Context
src/review/ams-reputation-bridge.ts:111-123's entry point bridgeAmsReputation declares its own precondition: callers must only invoke it once resolveConvergedFeature(env, manifest, "amsReputationBridge", repo) is true. But a repo-wide grep for bridgeAmsReputation returns exactly two hits: the definition and its own unit test — zero production call sites. resolveConvergedFeature(env, manifest, "amsReputationBridge", repo) is never called anywhere either. src/review/feature-activation.ts:80-89 registers the flag in FEATURE_GLOBAL_FLAG, but nothing consults it for this key. The actual reputation-signal consumer, src/review/reputation-wire.ts:74-92 (getEffectiveSubmitterReputation, read by shouldSkipAiForReputation), never imports from ams-reputation-bridge.ts/ams-reputation-bridge-wire.ts at all. Meanwhile .loopover.yml.example:1188-1195 documents this as a live, operator-configurable feature in the present tense with no "not yet wired" caveat. Issue #6485 ("Implement upgrade-only ORB/AMS reputation bridge") is closed with no open follow-up to actually wire it in.
Requirements
getEffectiveSubmitterReputation (or its caller shouldSkipAiForReputation, src/review/reputation-wire.ts) must call resolveConvergedFeature(env, manifest, "amsReputationBridge", repoFullName) and, when true, pass the locally-computed signal through bridgeAmsReputation (with endpoint: resolveAmsTrackRecordEndpoint(env)) before returning it.- A repo with the feature and both env gates on must observably upgrade a
neutral/low submitter to trusted when their AMS track record qualifies, verified end-to-end (not just at the unit level bridgeAmsReputation already has).
- With the feature off (any of the three gates unset), behavior must stay byte-identical to today — add a regression test asserting
getEffectiveSubmitterReputation/shouldSkipAiForReputation output is unchanged when the flag is off.
Deliverables
Test Coverage Requirements
99%+ Codecov patch coverage on every changed line and branch, plus the end-to-end and feature-off regression tests described above.
Expected Outcome
The documented amsReputationBridge feature actually affects the reputation gate when enabled, instead of being fully built but dead code.
Links & Resources
src/review/ams-reputation-bridge.ts:111-123, src/review/feature-activation.ts:80-89, src/review/reputation-wire.ts:74-92, .loopover.yml.example:1188-1195; closed issue #6485.
Context
src/review/ams-reputation-bridge.ts:111-123's entry pointbridgeAmsReputationdeclares its own precondition: callers must only invoke it onceresolveConvergedFeature(env, manifest, "amsReputationBridge", repo)is true. But a repo-wide grep forbridgeAmsReputationreturns exactly two hits: the definition and its own unit test — zero production call sites.resolveConvergedFeature(env, manifest, "amsReputationBridge", repo)is never called anywhere either.src/review/feature-activation.ts:80-89registers the flag inFEATURE_GLOBAL_FLAG, but nothing consults it for this key. The actual reputation-signal consumer,src/review/reputation-wire.ts:74-92(getEffectiveSubmitterReputation, read byshouldSkipAiForReputation), never imports fromams-reputation-bridge.ts/ams-reputation-bridge-wire.tsat all. Meanwhile.loopover.yml.example:1188-1195documents this as a live, operator-configurable feature in the present tense with no "not yet wired" caveat. Issue #6485 ("Implement upgrade-only ORB/AMS reputation bridge") is closed with no open follow-up to actually wire it in.Requirements
getEffectiveSubmitterReputation(or its callershouldSkipAiForReputation,src/review/reputation-wire.ts) must callresolveConvergedFeature(env, manifest, "amsReputationBridge", repoFullName)and, when true, pass the locally-computed signal throughbridgeAmsReputation(withendpoint: resolveAmsTrackRecordEndpoint(env)) before returning it.neutral/lowsubmitter totrustedwhen their AMS track record qualifies, verified end-to-end (not just at the unit levelbridgeAmsReputationalready has).getEffectiveSubmitterReputation/shouldSkipAiForReputationoutput is unchanged when the flag is off.Deliverables
bridgeAmsReputationwired intogetEffectiveSubmitterReputation/shouldSkipAiForReputationupgradeReputationSignal's upgrade-only contract)Test Coverage Requirements
99%+ Codecov patch coverage on every changed line and branch, plus the end-to-end and feature-off regression tests described above.
Expected Outcome
The documented
amsReputationBridgefeature actually affects the reputation gate when enabled, instead of being fully built but dead code.Links & Resources
src/review/ams-reputation-bridge.ts:111-123,src/review/feature-activation.ts:80-89,src/review/reputation-wire.ts:74-92,.loopover.yml.example:1188-1195; closed issue #6485.