Context
src/review/review-eligibility.ts:55-57 defines isIgnoredReviewAuthor as a thin boolean wrapper (return !decideReviewEligibility(input).eligible;) around the real, actively-used decideReviewEligibility (called from src/signals/settings-preview.ts and src/queue/processors.ts). isIgnoredReviewAuthor itself has zero callers outside its own test.
Requirements
- Confirm via a fresh repo-wide search that
isIgnoredReviewAuthor has zero real callers.
- Remove
isIgnoredReviewAuthor and its dedicated test case, since decideReviewEligibility already provides equivalent (and richer) information to every real caller.
Deliverables
Expected Outcome
No redundant convenience wrapper remains alongside the function it thinly wraps.
Links & Resources
src/review/review-eligibility.ts:55-57
src/signals/settings-preview.ts, src/queue/processors.ts (real callers of decideReviewEligibility)
Context
src/review/review-eligibility.ts:55-57definesisIgnoredReviewAuthoras a thin boolean wrapper (return !decideReviewEligibility(input).eligible;) around the real, actively-useddecideReviewEligibility(called fromsrc/signals/settings-preview.tsandsrc/queue/processors.ts).isIgnoredReviewAuthoritself has zero callers outside its own test.Requirements
isIgnoredReviewAuthorhas zero real callers.isIgnoredReviewAuthorand its dedicated test case, sincedecideReviewEligibilityalready provides equivalent (and richer) information to every real caller.Deliverables
isIgnoredReviewAuthorremoved fromreview-eligibility.ts.decideReviewEligibilitycontinue passing.Expected Outcome
No redundant convenience wrapper remains alongside the function it thinly wraps.
Links & Resources
src/review/review-eligibility.ts:55-57src/signals/settings-preview.ts,src/queue/processors.ts(real callers ofdecideReviewEligibility)