Skip to content

chore(review): remove unused isIgnoredReviewAuthor wrapper (thin duplicate of the actively-used decideReviewEligibility) #6169

Description

@JSONbored

Context

src/review/review-eligibility.ts:55-57 defines isIgnoredReviewAuthor as a thin boolean wrapper (return !decideReviewEligibility(input).eligible;) around the real, actively-used decideReviewEligibility (called from src/signals/settings-preview.ts and src/queue/processors.ts). isIgnoredReviewAuthor itself has zero callers outside its own test.

Requirements

  • Confirm via a fresh repo-wide search that isIgnoredReviewAuthor has zero real callers.
  • Remove isIgnoredReviewAuthor and its dedicated test case, since decideReviewEligibility already provides equivalent (and richer) information to every real caller.

Deliverables

  • isIgnoredReviewAuthor removed from review-eligibility.ts.
  • Its dedicated test case removed; remaining tests for decideReviewEligibility continue passing.

Expected Outcome

No redundant convenience wrapper remains alongside the function it thinly wraps.

Links & Resources

  • src/review/review-eligibility.ts:55-57
  • src/signals/settings-preview.ts, src/queue/processors.ts (real callers of decideReviewEligibility)

Metadata

Metadata

Assignees

No one assigned

    Labels

    gittensor:bugGittensor-scored bug fix — scores a 0.05x multiplier.help wantedExtra attention is needed

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions