-
-
Notifications
You must be signed in to change notification settings - Fork 89
Build a real production runSlopAssessment implementation #5133
Copy link
Copy link
Closed
Labels
gittensor:featureGittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.maintainer-onlyOwner-only work — yields no Gittensor points.Owner-only work — yields no Gittensor points.
Description
Metadata
Metadata
Assignees
Labels
gittensor:featureGittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.maintainer-onlyOwner-only work — yields no Gittensor points.Owner-only work — yields no Gittensor points.
Problem:
attempt-runner.js's injectabledeps.runSlopAssessment(packages/gittensory-miner/lib/attempt-runner.js:23) has no production implementation anywhere in this package — the only non-type-signature reference outside the module itself is the test double intest/unit/miner-attempt-runner.test.ts:110(runSlopAssessment: () => noopSlop). The real self-review scorer (src/signals/slop.ts) is far larger and more interconnected with the main review-stack app, and was never adapted into a portable, injectable form the miner's iterate-loop can call.Area: AMS / Miner
Proposal: Build a real
runSlopAssessmentimplementation reusingsrc/signals/slop.ts's scoring logic (or its already-portablepackages/gittensory-engineequivalent, if one exists — check before assuming it doesn't) as an injectable dependency conforming toattempt-runner.js's expected shape, so a real attempt gets a genuine self-review pass instead of a no-op.Deliverables:
runSlopAssessmentfunction, wired as the default dependency for the CLI dispatch in the sibling issue.Acceptance criteria:
src/signals/slop.ts's judgment — not a reimplementation that can drift from the live gate's own scoring.miner-attempt-runner.test.tsis unaffected — the test double stays a test double, this issue only adds the real production path.Resources:
src/signals/slop.ts(the scorer to reuse).packages/gittensory-engine(check first whether this logic is already extracted here for byte-parity, per the project's established "engine = shared deterministic logic" pattern, before building a second copy).Boundaries:
Part of #5130.