Skip to content

PR for #160 Correct minus sign for tablefill#161

Open
zhizhongpu wants to merge 4 commits into
mainfrom
160-correct-minus-sign-for-tablefill
Open

PR for #160 Correct minus sign for tablefill#161
zhizhongpu wants to merge 4 commits into
mainfrom
160-correct-minus-sign-for-tablefill

Conversation

@zhizhongpu
Copy link
Copy Markdown
Collaborator

No description provided.

@zhizhongpu zhizhongpu linked an issue May 5, 2026 that may be closed by this pull request
@zhizhongpu zhizhongpu requested review from jmshapir and removed request for jmshapir May 5, 2026 20:54
@zhizhongpu
Copy link
Copy Markdown
Collaborator Author

zhizhongpu commented May 5, 2026

Interesting, maybe this doesn't work on windows. I'll think about this.

@zhizhongpu
Copy link
Copy Markdown
Collaborator Author

Status: I will look into this after July 1st.

@zhizhongpu zhizhongpu self-assigned this May 14, 2026
@zhizhongpu zhizhongpu requested a review from jmshapir May 14, 2026 01:39
@zhizhongpu
Copy link
Copy Markdown
Collaborator Author

@jmshapir I'm reasonably confident that this would be robust. Of course, I cannot foresee scenarios that I don't know, but the good news is that I'll be available for a while to maintain it.

Copy link
Copy Markdown
Contributor

@jmshapir jmshapir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhizhongpu thanks. Should we recompile (the relevant portions of) Template to verify that it works? If we need an example we could add, say, the difference between GDP per capita in Norway and Lichtenstein to the table.

@zhizhongpu
Copy link
Copy Markdown
Collaborator Author

Should we recompile (the relevant portions of) Template to verify that it works?

thanks @jmshapir. I was wondering about this. In particular, despite the SConscript specifications

target = ['#output/paper/TemplateLyx.pdf']
source = ['#source/paper/Template.lyx',
'#output/tables/top_gdp.lyx',
'#output/analysis/top_gdp/top_gdp.tex',
'#source/figures/gdp_educ.lyx',
'#source/paper/References.bib']
env.Lyx(target, source)
target = ['#output/paper/TemplateTex.pdf']
source = ['#source/paper/Template.tex',
'#output/tables/top_gdp.tex',
'#output/analysis/top_gdp/top_gdp.tex',
'#source/figures/gdp_educ.tex',
'#source/paper/References.bib']
and
target = ['#output/talk/TemplateSlides.pdf', '#temp/Template.handout.pdf']
source = ['#source/talk/TemplateSlides.lyx',
'#output/analysis/plots/gdp_educ.eps']
env.Lyx(target, source)
target = ['#output/talk/TemplateSlidesLatex.pdf', '#temp/TemplateLatex.handout.pdf']
source = ['#source/talk/TemplateSlides.tex',
'#output/analysis/plots/gdp_educ.eps']
env.Latex(target, source)
, output/paper and output/talk have been empty since at least two years ago. Is that intentional?

If we need an example we could add, say, the difference between GDP per capita in Norway and Lichtenstein to the table.

Will do. Would you also like to illustrate, by the way, the use case of filling two panels of the same lyx table using two separate txt tables? A reader might find that either more useful or more complicated.

@jmshapir
Copy link
Copy Markdown
Contributor

, output/paper and output/talk have been empty since at least two years ago. Is that intentional?

If you mean these omissions:

- Files tracked by git-lfs are ignored in `output/` because [git-lfs files are not permitted in a template repository](https://github.community/t/lfs-support-for-template-repos/122449).

then yes!

Will do. Would you also like to illustrate, by the way, the use case of filling two panels of the same lyx table using two separate txt tables? A reader might find that either more useful or more complicated.

I agree with the tradeoffs and my instinct is no.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Correct minus sign for tablefill

3 participants