adding ecflow requirement for ewok-env

[ashley314]

Description

I found when building and using spack-stack 2.1 on discover, the ecflow module got loaded with the gcc build but not with the oneapi build. This PR adds the ecflow requirement to ewok-env.

jedipara@discover33:/gpfsm/dswdev/jcsda/spack-stack/scu17/spack-stack-2.1.0/envs/ue-oneapi-2024.2.0> grep ewok-env log.concretize 
 -   k7u3wmq  ewok-env@1.0.0~cylc~ecflow~ewok~mysql~r2d2~solo build_system=bundle platform=linux os=sles15 target=zen3
jedipara@discover33:/gpfsm/dswdev/jcsda/spack-stack/scu17/spack-stack-2.1.0/envs/ue-oneapi-2024.2.0> grep ewok-env ../ue-gcc-13.4.0/log.concretize 
 -   gb5e4ur  ewok-env@1.0.0~cylc+ecflow~ewok~mysql~r2d2~solo build_system=bundle platform=linux os=sles15 target=zen3

Dependencies

None

Issues addressed

None ...

Applications affected

List all known applications (UFS WM, JEDI, SRW, etc.) intentionally or unintentionally affected by this PR.

Systems affected

List all systems intentionally or unintentionally affected by this PR.

Testing

• CI: Note whether the automatic tests (GitHub actions tests that run automatically for every commit) pass or not
  • GitHub actions CI tests pass
  • GitHub actions CI tests do not pass (provide explanation)
  • GitHub actions CI tests skipped (provide explanation if necessary)
• New tests added: List and describe any new tests added to GitHub actions
  • ...
• Additional testing: Add information on any additional tests conducted
  • ...

Checklist

• This PR addresses one issue/problem/enhancement or has a very good reason for not doing so.
• These changes have been tested on the affected systems and applications.
• All dependency PRs/issues have been resolved and this PR can be merged.
• All necessary updates to the documentation (spack-stack wiki) will be made when this PR is merged

[climbfuji]

This is a tricky one, because it would force us to go back and rebuild everywhere because you are modifying common packages.yaml.

The correct way imo to do this for release/2.1 is to force +ecflow in the discover site config (similar to how you force it be ~ecflow for atlantis) and not modify atlantis/common. Going forward, you will want to make your suggested changes in develop.

[ashley314]

@climbfuji great, thanks for that recommendation. I will update my discover PR with those changes and we can consider it for develop later.