This repository was archived by the owner on Jul 13, 2026. It is now read-only.
Replace ImportError with logging.warning if dpctl version is not met#925
Merged
Conversation
oleksandr-pavlyk
requested review from
diptorupd and
mingjie-intel
as code owners
February 21, 2023 20:52
oleksandr-pavlyk
force-pushed
the
soften-dpctl-version-check
branch
from
February 21, 2023 21:23
378e022 to
c010afc
Compare
Contributor
|
Merge based on public CI. |
github-actions Bot
added a commit
that referenced
this pull request
Feb 21, 2023
Replace ImportError with logging.warning if dpctl version is not met 63b8796
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If dpctl was built from source without
.gitfolder present,dpctl.__version__is0+unknownanddpctl_versioncomputation innumba_dpex/dpctl_support.pybroke down.Introduced function to safely infer
dpctl_version, and modifiedconfig.pyto issue softlogging.warningabout unmet dpctl version instead of raising hardImportError.