This repository was archived by the owner on Jul 13, 2026. It is now read-only.
Repository navigation
Support tests on single point precision GPUs - #1143
Merged
diptorupd merged 1 commit intoSep 27, 2023
Merged
Conversation
ZzEeKkAa
force-pushed
the
feature/support_tests_on_single_point_precision_gpu
branch
4 times, most recently
from
September 27, 2023 14:30
ae1196e to
ef901b3
Compare
ZzEeKkAa
force-pushed
the
feature/support_tests_on_single_point_precision_gpu
branch
from
September 27, 2023 14:54
ef901b3 to
0802633
Compare
ZzEeKkAa
marked this pull request as ready for review
September 27, 2023 14:57
diptorupd
approved these changes
Sep 27, 2023
diptorupd
left a comment
Contributor
There was a problem hiding this comment.
Thank you. Great changes. Please merge after CI is green
diptorupd
deleted the
feature/support_tests_on_single_point_precision_gpu
branch
September 27, 2023 15:54
github-actions Bot
added a commit
that referenced
this pull request
Sep 27, 2023
…ngle_point_precision_gpu Support tests on single point precision GPUs b85d379
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of the integrated GPUs does not support doble precision and numba by default uses double precision floats. That makes our tests fail on those GPUs. This changes targeted to add support for tests on single precision GPUs by:
Discovered issues:
arctan2does not work forfloat32if device does not supportfloat64(silent crash)parfor_divideandparfor_exponentdoes not work onint32andint64if device does not supportfloat64(lowering error)Issue checks: