Suppress the compiler warnings marking them as external#2770
Merged
Conversation
antonwolfy
force-pushed
the
suppress-compiler-warnings
branch
from
97f2404 to
2e328bf
Compare
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.20.0dev3=py313h509198e_7 ran successfully. |
Collaborator
antonwolfy
force-pushed
the
suppress-compiler-warnings
branch
2 times, most recently
from
80060c0 to
7b219fc
Compare
antonwolfy
force-pushed
the
suppress-compiler-warnings
branch
from
cd4fb3d to
f016807
Compare
antonwolfy
requested review from
ndgrigorian and
vlad-perevezentsev
as code owners
vlad-perevezentsev
approved these changes
Feb 17, 2026
vlad-perevezentsev
left a comment
vlad-perevezentsev
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Thank you @antonwolfy !
github-actions Bot
added a commit
that referenced
this pull request
Feb 17, 2026
On Linux, the DPC++ compiler headers are automatically treated as system headers. But it is not the case on Windows. Due to that, there is a ton of deprecation warnings generated inside the compiler headers when building dpnp extensions on Windows. This PR updates CMake files of the extensions to add include of DPC++ compiler headers explicitly and to mark the compiler and dpctl headers as system one to suppress the warning inside them. 30f5fd1
7 tasks
antonwolfy
added a commit
that referenced
this pull request
Jul 6, 2026
…ensor` on Windows (#2984) This PR is a follow-up to #2856 and #2770. The `dpnp.tensor` target never got the same `SYSTEM` treatment, so it was the one target still leaking these warnings. The Windows conda build produced a flood of `-Wdeprecated-declarations` warnings (hundreds of thousands of lines in the CI log). All of them originate inside the DPC++/SYCL headers themselves (`.../Library/include/sycl/...`) — none come from dpnp's own sources — so they are out of dpnp's control and are pure noise. They came exclusively from the `dpnp.tensor` `_tensor_*_impl` pybind11 modules built in `dpnp/tensor/CMakeLists.txt`. In the `dpnp/tensor` target loop, split the include directories so dpnp's own headers stay `PRIVATE`, and the third-party headers (`SYCL_INCLUDE_DIR`, `Dpctl_INCLUDE_DIR`, generated Cython headers) are added as `SYSTEM PRIVATE`, mirroring the pattern established in #2770 for the `backend/extensions/*` targets.
antonwolfy
added a commit
that referenced
this pull request
Jul 8, 2026
…ensor` on Windows (#2993) Re-land of #2984. That PR was a stacked PR targeting the intermediate branch `pin-conda-to-avoid-installing-faulty-build`, whose own PR (#2982) was **closed, not merged**. As a result, #2984 was merged into that dead intermediate branch and its changes never reached `master`. GitHub won't allow reopening a merged PR, so this re-lands the identical change directly against `master`. This is a follow-up to #2856 and #2770. The `dpnp.tensor` target never got the same `SYSTEM` treatment, so it was the one target still leaking these warnings. The Windows conda build produced a flood of `-Wdeprecated-declarations` warnings (hundreds of thousands of lines in the CI log). All of them originate inside the DPC++/SYCL headers themselves (`.../Library/include/sycl/...`) — none come from dpnp's own sources — so they are out of dpnp's control and are pure noise. They came exclusively from the `dpnp.tensor` `_tensor_*_impl` pybind11 modules built in `dpnp/tensor/CMakeLists.txt`. In the `dpnp/tensor` target loop, split the include directories so dpnp's own headers stay `PRIVATE`, and the third-party headers (`SYCL_INCLUDE_DIR`, `Dpctl_INCLUDE_DIR`, generated Cython headers) are added as `SYSTEM PRIVATE`, mirroring the pattern established in #2770 for the `backend/extensions/*` targets.
github-actions Bot
added a commit
that referenced
this pull request
Jul 8, 2026
…ensor` on Windows (#2993) Re-land of #2984. That PR was a stacked PR targeting the intermediate branch `pin-conda-to-avoid-installing-faulty-build`, whose own PR (#2982) was **closed, not merged**. As a result, #2984 was merged into that dead intermediate branch and its changes never reached `master`. GitHub won't allow reopening a merged PR, so this re-lands the identical change directly against `master`. This is a follow-up to #2856 and #2770. The `dpnp.tensor` target never got the same `SYSTEM` treatment, so it was the one target still leaking these warnings. The Windows conda build produced a flood of `-Wdeprecated-declarations` warnings (hundreds of thousands of lines in the CI log). All of them originate inside the DPC++/SYCL headers themselves (`.../Library/include/sycl/...`) — none come from dpnp's own sources — so they are out of dpnp's control and are pure noise. They came exclusively from the `dpnp.tensor` `_tensor_*_impl` pybind11 modules built in `dpnp/tensor/CMakeLists.txt`. In the `dpnp/tensor` target loop, split the include directories so dpnp's own headers stay `PRIVATE`, and the third-party headers (`SYCL_INCLUDE_DIR`, `Dpctl_INCLUDE_DIR`, generated Cython headers) are added as `SYSTEM PRIVATE`, mirroring the pattern established in #2770 for the `backend/extensions/*` targets. 6671952
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Linux, the DPC++ compiler headers are automatically treated as system headers. But it is not the case on Windows.
Due to that, there is a ton of deprecation warnings generated inside the compiler headers when building dpnp extensions on Windows.
This PR updates CMake files of the extensions to add include of DPC++ compiler headers explicitly and to mark the compiler and dpctl headers as system one to suppress the warning inside them.