Skip to content

Remove deprecated dpctl.tensor submodule#2245

Merged
ndgrigorian merged 26 commits into
masterfrom
feature/uncouple-tensor-from-dpctl
Apr 13, 2026
Merged

Remove deprecated dpctl.tensor submodule#2245
ndgrigorian merged 26 commits into
masterfrom
feature/uncouple-tensor-from-dpctl

Conversation

@ndgrigorian

@ndgrigorian ndgrigorian commented Feb 5, 2026

Copy link
Copy Markdown
Collaborator

This PR removes the dpctl.tensor submodule, as it is migrated to dpnp as dpnp.tensor

This change makes dpctl a much smaller, lighter-weight package, with no built-in tensor capabilities. The memory sub-module and order_manager remain to support tensor-like extensions, but dpctl will focus on device management and providing a Python interface to SYCL implementations

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@ndgrigorian
ndgrigorian force-pushed the feature/uncouple-tensor-from-dpctl branch from dcac1f6 to e450664 Compare February 17, 2026 02:08
@github-actions

github-actions Bot commented Feb 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@ndgrigorian
ndgrigorian marked this pull request as ready for review February 18, 2026 04:01
@ndgrigorian
ndgrigorian force-pushed the feature/uncouple-tensor-from-dpctl branch from da4c41e to 6a5046b Compare April 2, 2026 20:22
@ndgrigorian

ndgrigorian commented Apr 2, 2026

Copy link
Copy Markdown
Collaborator Author

@antonwolfy @vlad-perevezentsev
With work almost done in dpnp, please review this when you have the chance

@ndgrigorian
ndgrigorian force-pushed the feature/uncouple-tensor-from-dpctl branch from 6a5046b to 7d8bbc8 Compare April 7, 2026 18:36
antonwolfy
antonwolfy reviewed Apr 8, 2026
View reviewed changes
Comment thread dpctl/__init__.py
@ndgrigorian
ndgrigorian force-pushed the feature/uncouple-tensor-from-dpctl branch from 7d8bbc8 to b610ee3 Compare April 11, 2026 00:06
@ndgrigorian
ndgrigorian requested a review from antonwolfy April 11, 2026 00:12
vlad-perevezentsev
vlad-perevezentsev reviewed Apr 13, 2026
View reviewed changes
Comment thread docs/doc_sources/user_guides/index.rst Outdated
Comment thread CHANGELOG.md
Comment thread scripts/gen_coverage.py Outdated
Comment thread docs/doc_sources/license.rst
Comment thread docs/doc_sources/license.rst
@ndgrigorian
remove entire tensor submodule and modify cmake accordingly
aec4350
@ndgrigorian
remove benchmarks
10f7ae2
@ndgrigorian
remove tensor from dpctl cmake
43c5dd5
@ndgrigorian
remove array API workflow
d11f0c0
@ndgrigorian
remove tensor from linting and gitignore
596f800
@ndgrigorian
remove tensor from coverage testing
d67be02
@ndgrigorian
remove tensor-related options from dpctl module call
81848cf
@ndgrigorian
remove skip_if_dtype_not_supported test utility
7c811b0
@ndgrigorian
remove references to dpctl.tensor in docstrings
634394d
@ndgrigorian
Update dpctl tests to remove dpctl.tensor
1316c75
@ndgrigorian
remove _compute_follows_data.pyx as it is no longer applicable to the…
454ba1d 
… project sans tensor
@ndgrigorian
remove cython/usm_memory example
8b54735
@ndgrigorian
remove solver from onemkl example
f786531
@ndgrigorian
remove python/sycl_timer example
576be4a
@ndgrigorian
Update gemv example to remove calls to dpctl.tensor
159bf61
@ndgrigorian
Update dpctl sycl kernel example
f8cd405
@ndgrigorian
Update tests for external USM allocation example
5e2cd14
@ndgrigorian
remove test for tensor includes
32f5197
@ndgrigorian
ndgrigorian force-pushed the feature/uncouple-tensor-from-dpctl branch from b610ee3 to dd74214 Compare April 13, 2026 16:47
vlad-perevezentsev
vlad-perevezentsev reviewed Apr 13, 2026
View reviewed changes
Comment thread .flake8 Outdated
Comment thread .flake8 Outdated
vlad-perevezentsev
vlad-perevezentsev approved these changes Apr 13, 2026
View reviewed changes

@vlad-perevezentsev vlad-perevezentsev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more comments from my side, LGTM
Thank you @ndgrigorian !

I also tested these changes with include-dpctl-tensor branch in dpnp.
The build and tests did not find any issues

@antonwolfy сould you please also review this?

antonwolfy
antonwolfy approved these changes Apr 13, 2026
View reviewed changes

@antonwolfy antonwolfy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ndgrigorian
ndgrigorian merged commit 7be739f into master Apr 13, 2026
71 of 73 checks passed
@ndgrigorian
ndgrigorian deleted the feature/uncouple-tensor-from-dpctl branch April 13, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes
@antonwolfy antonwolfy antonwolfy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ndgrigorian @vlad-perevezentsev @antonwolfy