Skip to content

DOC: Do not require using NumericTraits, replace ZeroValue() with {} #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jhlegarreta merged 1 commit into from
Mar 14, 2023
Merged

DOC: Do not require using NumericTraits, replace ZeroValue() with {} #197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions SoftwareGuide/Latex/Appendices/CodingStyleGuide.tex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1575,9 +1575,9 @@ \section{Initialization and Assignment}
double m_Thickness{ 1.0 };
bool m_Normalize{ false };
bool m_BrightCenter{ false };
PixelType m_InteriorValue{ NumericTraits<PixelType>::ZeroValue() };
PixelType m_InteriorValue{};
PixelType m_AnnulusValue{ NumericTraits<PixelType>::OneValue() };
PixelType m_ExteriorValue{ NumericTraits<PixelType>::ZeroValue() };
PixelType m_ExteriorValue{};
SpacingType m_Spacing{ 1.0 };
\end{minted}
\normalsize
Expand All @@ -1598,7 +1598,7 @@ \section{Initialization and Assignment}
\begin{minted}[baselinestretch=1,fontsize=\footnotesize,linenos=false,bgcolor=ltgray]{cpp}
template <typename TInputImage, typename TOutputImage>
SpecializedFilter<TInputImage, TOutputImage>::SpecializedFilter()
: m_BackgroundValue(NumericTraits<OutputImagePixelType>::ZeroValue())
: m_BackgroundValue{}
, m_ForegroundValue(NumericTraits<OutputImagePixelType>::OneValue())
{
...
Expand All @@ -1613,7 +1613,7 @@ \section{Initialization and Assignment}
template <typename TInputImage, typename TOutputImage>
SpecializedFilter<TInputImage, TOutputImage>::SpecializedFilter()
{
m_BackgroundValue = NumericTraits<OutputImagePixelType>::ZeroValue();
m_BackgroundValue = {};
m_ForegroundValue = NumericTraits<OutputImagePixelType>::OneValue();

...
Expand All @@ -1639,10 +1639,6 @@ \section{Initialization and Assignment}
example \code{FixedArray::m\_InternalArray} and \code{Index::m\_InternalArray}
do not have a default member initializer.

Note that all numeric data members must be initialized using the appropriate
ITK's \code{NumericTraits} static method.


\section{Accessing Members}
\label{sec:Accessing Members}

Expand Down Expand Up @@ -2231,7 +2227,7 @@ \subsection{White Spaces}
template <typename TInputImage, typename TOutputImage>
SpecializedFilter<TInputImage, TOutputImage>::SpecializedFilter()
: m_ForegroundValue(NumericTraits<InputImagePixelType>::max())
, m_BackgroundValue(NumericTraits<InputImagePixelType>::ZeroValue())
, m_BackgroundValue{}
, m_NumPixelComponents(0)
, m_NoiseSigmaIsSet(false)
, m_SearchSpaceList(ListAdaptorType::New())
Expand Down