fix(docs): resolve Maven site template variables - #439
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #439 +/- ##
=======================================
Coverage 88.73% 88.73%
=======================================
Files 21 21
Lines 1553 1553
Branches 281 281
=======================================
Hits 1378 1378
Misses 77 77
Partials 98 98 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟢 Approval recommended
The changes are narrowly scoped to Maven Site configuration and appear consistent with the stated validation results and issue fix intent.
Pull request overview
Updates the project’s Maven Site descriptor to ensure template variables (e.g., ${project.name}) resolve correctly in the generated GitHub Pages documentation, addressing the issue reported in #438.
Changes:
- Migrated
src/site/site.xmlfrom Decoration Model 1.8.0 to Site Model 2.0.0. - Upgraded the Maven Fluido skin version to
2.1.0to align with Maven Site Plugin3.22.0. - Added a changelog entry documenting the documentation-site fix.
File summaries
| File | Description |
|---|---|
| src/site/site.xml | Switches to Site Model 2.0.0 and updates the Fluido skin version to prevent unresolved template variables in generated site output. |
| CHANGELOG.md | Records the documentation-site fix under the upcoming release notes. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Closes #438
Proposed Changes
src/site/site.xmlto Site Model 2.0.0.Checklist
Validation Notes
mvn -B -DskipTests sitepassed; generated top-level pages contain no unresolved template expressions.mvn -B -DskipTests verifypassed, including checkstyle and license checks.RST_STREAM ... CANCEL/ Arrow Unsafe).main; GitHub CI is still running.