Skip to content

fix(docs): resolve Maven site template variables - #439

Open
bednar wants to merge 2 commits into
mainfrom
codex/fix-site-doc-variables
Open

fix(docs): resolve Maven site template variables#439
bednar wants to merge 2 commits into
mainfrom
codex/fix-site-doc-variables

Conversation

@bednar

@bednar bednar commented Sep 10, 2026

Copy link
Copy Markdown
Member

Closes #438

Proposed Changes

  • Migrate src/site/site.xml to Site Model 2.0.0.
  • Update the Maven Fluido skin to 2.1.0, compatible with Maven Site Plugin 3.22.0.
  • Preserve the project banner and site navigation with the current descriptor schema.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional
  • Sign CLA (if not already signed)

Validation Notes

  • mvn -B -DskipTests site passed; generated top-level pages contain no unresolved template expressions.
  • mvn -B -DskipTests verify passed, including checkstyle and license checks.
  • Targeted tests passed: 296 tests, 0 failures, 28 skipped.
  • The full test suite currently has 6 failures and 9 errors in existing FlightSQL/query tests on this JDK (RST_STREAM ... CANCEL / Arrow Unsafe).
  • The PR is mergeable but currently behind main; GitHub CI is still running.
image

@codecov

codecov Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.73%. Comparing base (eae63b0) to head (f1b129a).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #439   +/-   ##
=======================================
  Coverage   88.73%   88.73%           
=======================================
  Files          21       21           
  Lines        1553     1553           
  Branches      281      281           
=======================================
  Hits         1378     1378           
  Misses         77       77           
  Partials       98       98           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bednar
bednar requested review from karel-rehor and a lite review from Copilot September 10, 2026 08:20

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes are narrowly scoped to Maven Site configuration and appear consistent with the stated validation results and issue fix intent.

Pull request overview

Updates the project’s Maven Site descriptor to ensure template variables (e.g., ${project.name}) resolve correctly in the generated GitHub Pages documentation, addressing the issue reported in #438.

Changes:

  • Migrated src/site/site.xml from Decoration Model 1.8.0 to Site Model 2.0.0.
  • Upgraded the Maven Fluido skin version to 2.1.0 to align with Maven Site Plugin 3.22.0.
  • Added a changelog entry documenting the documentation-site fix.
File summaries
File Description
src/site/site.xml Switches to Site Model 2.0.0 and updates the Fluido skin version to prevent unresolved template variables in generated site output.
CHANGELOG.md Records the documentation-site fix under the upcoming release notes.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Site documentation is not resolving variables correctly

2 participants