Add handleChipRemove for all chip samples#980
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds handleChipRemove event handlers to all chip sample components to properly handle the removal of chips when users click the remove button. This ensures chips are actually removed from the DOM when the remove icon is clicked.
Key Changes:
- Added
handleChipRemovemethod to five chip sample components - Connected the handlers to
onRemoveprops on all removable IgrChip instances
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| samples/inputs/chip/variants/src/index.tsx | Added chip removal handler for variant chips (primary, info, success, warning, danger) |
| samples/inputs/chip/styling/src/index.tsx | Added chip removal handler for the styled chip sample |
| samples/inputs/chip/size/src/index.tsx | Added chip removal handler for size variant chips (small, medium, large) |
| samples/inputs/chip/overview/src/index.tsx | Added chip removal handler for the basic chip overview sample |
| samples/inputs/chip/multiple/src/index.tsx | Added chip removal handler for the multiple chips sample with custom icons |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ddaribo
approved these changes
Dec 2, 2025
ddaribo
added
status: verified
HUSSAR-mtrela
added a commit
that referenced
this pull request
Dec 15, 2025
* fix(text-area): add gap to resize sample (#971) * fix(calendar-formatting): set radio value to state (#977) * Add handleChipRemove for all chip samples (#980) * fix(chip): add handleChipRemove for all chip samples * chore(chip): apply review suggestions * Adding changes from build igniteui-xplat-examples-output+PRs_2025.12.5.2 * CDN update (#986) * cdn update * cdn update * cdn update * cdn path css * fix names * cdn gen data * Update index.tsx * cdn path to images * fixed names * Adding changes from build igniteui-xplat-examples-output+PRs_2025.12.5.3 (#987) Co-authored-by: tfsbuild <tfsbuild@infragistics.com> * CDN improvements (#988) * simplified data lite source * fix igniteui-grid-lite package * fixed men/women to CDN images * fix /browsers/ig.png * update performance sample * fixed /img/avatars/ * cdn readme images * CDN improvements (#989) * sb CDN * Update index.tsx * 19.3.1-beta.0 19.3.1-beta.0 * mdd-update-19.3.1 (#991) mdd-update-19.3.1 * Update package-lock.json --------- Co-authored-by: Riva Ivanova <49126110+RivaIvanova@users.noreply.github.com> Co-authored-by: Bozhidara Pachilova <35433937+ddaribo@users.noreply.github.com> Co-authored-by: MonikaKirkova <47036441+MonikaKirkova@users.noreply.github.com> Co-authored-by: tfsbuild <tfsbuild@infragistics.com> Co-authored-by: Deyan Kamburov <dkamburov@users.noreply.github.com> Co-authored-by: azure-pipelines[bot] <36771401+azure-pipelines[bot]@users.noreply.github.com> Co-authored-by: mddifilippo89 <mdifilippo@infragistics.com> Co-authored-by: IGvaleries <vsuszynski@infragistics.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #979