fix(design): migrate ContextBreakdown to semantic design tokens - #158
Merged
Conversation
Replace hardcoded hex colors, Tailwind radius, and duration classes
with semantic design-system tokens to pass the check:design CI gate.
- Add --ds-color-chart-{1..6} foundation + semantic tokens (light/dark)
- Replace raw #hex values with var(--ds-color-chart-*) references
- Replace rounded-sm with rounded-(--ds-radius-micro)
- Replace duration-300 with duration-(--ds-motion-page)
Co-authored-by: Cursor <cursoragent@cursor.com>
The lucide-react package is not installed; ContextBreakdown imported X from it, causing 12 test failures across both CI workflows. Switch to the project's @/components/ui/icons module. Co-authored-by: Cursor <cursoragent@cursor.com>
- split-button.tsx: replace lucide-react import with project icon system - App.tsx: add missing breakdown field to satisfy ContextWindow type - SourceControl.tsx: remove unused standalone push function Co-authored-by: Cursor <cursoragent@cursor.com>
- desktop-design-system.yml: add macOS + Windows test matrix alongside the existing Ubuntu validate job (design check + tests + build) - windows-desktop.yml: remove pull_request trigger; full Windows installer packaging now only runs on push to main or workflow_dispatch PR feedback stays fast (~30s validate + parallel cross-platform tests). Full 90-minute Windows build no longer blocks PR review. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--ds-color-chart-{1..6}foundation and semantic tokens with light/dark variants totokens.cssContextBreakdown.tsxwithvar(--ds-color-chart-*)referencesrounded-smwithrounded-(--ds-radius-micro)to use the design system radius scaleduration-300(2 occurrences) withduration-(--ds-motion-page)to use semantic motion tokensFixes the
desktop-design-systemCI workflow that has been failing on every push tomain.Test plan
bun run check:designpasses locally with 0 new violationsdesktop-design-systemworkflow passes on this PRMade with Cursor