fix(mobile): refresh live thread replies on websocket fallback - #1
Draft
IcantCode1010 wants to merge 1 commit into
Draft
fix(mobile): refresh live thread replies on websocket fallback#1IcantCode1010 wants to merge 1 commit into
IcantCode1010 wants to merge 1 commit into
Conversation
Signed-off-by: IcantCode1010 <86989251+IcantCode1010@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
threadRepliesProvideris a one-shot future. Its invalidation previously ran only through the channel-window merge path, so a client that fell back to websocket history could receive a reply without refreshing an already-open thread. Restarting the app rebuilt the provider and revealed the missing reply.User impact
Open threads refresh when live replies arrive on the websocket fallback path, without requiring the mobile app to restart.
Security review
The change adds no dependencies, permissions, storage, logging, deep links, or Android components. It invalidates only channel-scoped thread queries for existing channel timeline reply kinds and retains the current relay query filters and event handling.
Verification
dart format --output=none --set-exit-if-changed .flutter analyzeflutter test test/features/channels/channel_messages_provider_test.dart(16 passed)flutter test(1,089 passed, 1 skipped)git diff --checkRelated upstream issue: block#3046
Related upstream work: block#3243