48208 - Test question list no longer shows the total points of the question set - #12030
Closed
lorenzgith wants to merge 1 commit into
Closed
Conversation
Contributor
|
Thank you very much for the PR @lorenzgith ! I will close this though and continue in this PR as there is more "meat" there. Thanks again and best, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://mantis.ilias.de/view.php?id=48208
In ILIAS 9 the questions list of a test showed the total points of the fixed question set in the header of the Points column.
ilTestQuestionsTableGUIkept the sum and appended it to the column title. After the migration to the new UI table framework the total is no longer displayed anywhere in the list view; it only survives in the print view (Printer.php).That makes editing a test harder than before, because the achievable total is exactly the number an author needs while adding, removing or re-weighting questions.
The summation logic still exists and is unchanged (
ilObjTest::getFixedQuestionSetTotalPoints()), it is simply no longer called. This uses it again when building the column header, limited to fixed question sets since the sum is not meaningful for random tests.The number is labelled with the existing language variable
total, so the header readsPoints (Total: 42)rather than showing a bare number in parentheses as ILIAS 9 did. Since the label is part of the column header text, it is announced by screen readers as well.