48279 - Participants tab fails to render when the percentage column is enabled - #12029
Closed
lorenzgith wants to merge 1 commit into
Closed
48279 - Participants tab fails to render when the percentage column is enabled#12029lorenzgith wants to merge 1 commit into
lorenzgith wants to merge 1 commit into
Conversation
Contributor
|
Thank you very much for the PR @lorenzgith ! I picked your changes manually, as I wanted to have a value that was consistent with the return type of the function, but you are clearly still the author. Best, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://mantis.ilias.de/view.php?id=48279
As soon as the optional column for the achieved percentage is switched on in the participants table of a test, the whole tab stops rendering:
percent_of_available_pointsis anumber()column, but the row value is built with the null-safe operator and no fallback, so a participant without an attempt yieldsnull. The renderer then hands thatnulltonumber_format()and the whole table fails, not just the affected cell.The neighbouring values in the same method all do provide a fallback (
total_attempts ?? 0,test_passed ?? false,total_time_on_task ?? ''); only the percentage lacks one. This adds?? 0accordingly.If an empty cell is preferred over a zero for participants without an attempt, letting the number column render
nullwould be the alternative, but the fallback is the smaller and more consistent change.