48273 - Fix question hint title in test player - #12015
Merged
kergomard merged 1 commit intoSep 4, 2026
Merged
Conversation
Contributor
|
Hi @iFadi Thank you for the PR. Merged. This is ILIAS 10 only, as we do not have any hints anymore in ILIAS 11. Best, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Uses the question object already held by
ilAssQuestionHintRequestGUIwhen rendering hint page titles.In the test player, the parent GUI returns an
ilObjTest. CallinggetTitleForHTMLOutput()on that object causes a fatal error. The hint GUI already has the corresponding question object, which provides the required HTML-safe title.Mantis: https://mantis.ilias.de/view.php?id=48273
Tests
showListCmd()andshowHintCmd()in test-player context.ilAssQuestionHintRequestGUITest: 2 tests, 5 assertions.