[FIX] OIDC: Handle object-shaped role claims in role assignment - #12009
Open
mjansenDatabay wants to merge 1 commit into
Open
[FIX] OIDC: Handle object-shaped role claims in role assignment#12009mjansenDatabay wants to merge 1 commit into
mjansenDatabay wants to merge 1 commit into
Conversation
parseRoleAssignments() treated any non-array role claim as a string. Providers that deliver roles as a JSON object keyed by role name (e.g. Zitadel) made PHP throw when casting stdClass to string, so login failed instead of assigning roles. Role claims are now normalized to a list of role names, including object maps, while keeping the existing string, string-list, and SCIM-like array handling. See: https://mantis.ilias.de/view.php?id=48270
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parseRoleAssignments() treated any non-array role claim as a string. Providers that deliver roles as a JSON object keyed by role name (e.g. Zitadel) made PHP throw when casting stdClass to string, so login failed instead of assigning roles.
Role claims are now normalized to a list of role names, including object maps, while keeping the existing string, string-list, and SCIM-like array handling.
See: https://mantis.ilias.de/view.php?id=48270