Skip to content

[Fix] #0048244 UI/Prompt: async state roundtrips can break client JS (forms / scripts / close-redirect) - #11986

Open
fhelfer wants to merge 1 commit into
ILIAS-eLearning:trunkfrom
fhelfer:ui/fix-prompt-async-client
Open

[Fix] #0048244 UI/Prompt: async state roundtrips can break client JS (forms / scripts / close-redirect)#11986
fhelfer wants to merge 1 commit into
ILIAS-eLearning:trunkfrom
fhelfer:ui/fix-prompt-async-client

Conversation

@fhelfer

@fhelfer fhelfer commented Aug 26, 2026

Copy link
Copy Markdown
Contributor
  • Hardens Prompt JS for asynchronous state roundtrips (null-safe state sections, script replace marker, safer re-init / signal rebinding).
  • Standalone bugfix; unrelated to confirmation / entity-input work.
    Fixes: https://mantis.ilias.de/view.php?id=48244

@fhelfer fhelfer added bugfix javascript Pull requests that update Javascript code labels Aug 26, 2026

@thibsy thibsy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fhelfer,

Thx a lot for the bugfix!

Please help me answer the following questions:

  • Do I understand correctly that this addresses two separate issues? One being the availability of all sections which is not always the case, the other being the JS code that is provided async that is not always or ever considered?
  • Could you look into whether we could replace the approach used inside the prompt JS using the DOMParser with the AsyncRenderer implementation of the UI framework? This should already take care of the scripts issue I think.

Thx for following up here.

Kind regards,
@thibsy (as UI coordinator)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix javascript Pull requests that update Javascript code kitchen sink

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants