Skip to content

test/formula_auditor_spec: add Linux-only GCC dep tests#21767

Merged
MikeMcQuaid merged 1 commit intomainfrom
formula_auditor-test-gcc
Mar 22, 2026
Merged

test/formula_auditor_spec: add Linux-only GCC dep tests#21767
MikeMcQuaid merged 1 commit intomainfrom
formula_auditor-test-gcc

Conversation

@cho-m
Copy link
Copy Markdown
Member

@cho-m cho-m commented Mar 19, 2026

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

Tests for

Copilot AI review requested due to automatic review settings March 19, 2026 14:47
@cho-m cho-m marked this pull request as draft March 19, 2026 14:48
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds RSpec coverage for Homebrew::FormulaAuditor#audit_gcc_dependency, validating the Linux-only GCC dependency audit behavior introduced/adjusted in #21765.

Changes:

  • Add specs ensuring the audit is skipped when not running on Linux.
  • Add specs that flag Linux-only depends_on "gcc" in homebrew/core on Linux.
  • Add specs covering allowlisted exceptions, implicit GCC deps, non-core taps, and non-OS-specific GCC deps.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@cho-m cho-m marked this pull request as ready for review March 19, 2026 15:39
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Mar 22, 2026
Merged via the queue into main with commit 8381c15 Mar 22, 2026
42 checks passed
@MikeMcQuaid MikeMcQuaid deleted the formula_auditor-test-gcc branch March 22, 2026 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants