Skip to content

test_bot/bottles_fetch: fetch bottles in parallel.#21503

Merged
MikeMcQuaid merged 1 commit intomainfrom
brew_test_bot_fetch_bottles_parallel
Feb 3, 2026
Merged

test_bot/bottles_fetch: fetch bottles in parallel.#21503
MikeMcQuaid merged 1 commit intomainfrom
brew_test_bot_fetch_bottles_parallel

Conversation

@MikeMcQuaid
Copy link
Copy Markdown
Member

This should make things faster.

Copilot AI review requested due to automatic review settings February 2, 2026 17:26
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the BottlesFetch class to batch bottle fetching operations by grouping formulae by their bottle tags. Instead of fetching bottles for each formula-tag combination individually, the code now groups all formulae by tag and fetches all formulae for a given tag in a single operation.

Changes:

  • Introduced a new formulae_by_tag method that groups formulae by their bottle tags
  • Modified fetch_bottles! to accept a tag and multiple formulae instead of a single formula
  • Reduced the number of brew fetch command invocations and cleanup checks by batching operations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MikeMcQuaid MikeMcQuaid enabled auto-merge February 2, 2026 20:56
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Feb 3, 2026
Merged via the queue into main with commit 6203165 Feb 3, 2026
43 checks passed
@MikeMcQuaid MikeMcQuaid deleted the brew_test_bot_fetch_bottles_parallel branch February 3, 2026 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants