os/mac/keg_relocate: be stricter about preferred_perl#21501
Merged
MikeMcQuaid merged 1 commit intomainfrom Feb 2, 2026
Merged
Conversation
Ensure that we validate the format here.
MikeMcQuaid
force-pushed
the
preferred_perl_version_stricter
branch
from
b6fc600 to
5bdd4a7
Compare
Rylan12
approved these changes
Feb 2, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves validation for the preferred_perl field in keg relocation logic by enforcing a stricter format check. The change ensures that the preferred Perl version follows the expected pattern before being used, preventing potential issues with malformed version strings.
Changes:
- Added format validation for
preferred_perlusing a regex pattern to ensure it matches the expected\d+\.\d+format - Restructured the conditional logic to validate both the presence and format of
preferred_perlbefore using it - Removed the fallback logic that would use
MacOS.preferred_perl_versionwhen the perl_path doesn't exist
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that we validate the format here.