bundle: dump full cask names

[gromgit]

This mirrors existing 3rd-party formulae disambiguation.

Fixes #21416.

Before:

% brew bundle dump --file=- | grep -E '(jq|pup|font)'
tap "colindean/fonts-nonfree"
brew "jq"
brew "gromgit/tap/pup"
cask "font-dseg"
cask "font-lato"
cask "font-microsoft-office"

After:

% brew bundle dump --file=- | grep -E '(jq|pup|font)'
tap "colindean/fonts-nonfree"
brew "jq"
brew "gromgit/tap/pup"
cask "rami3l/tap/font-dseg"
cask "font-lato"
cask "colindean/fonts-nonfree/font-microsoft-office"

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

[MikeMcQuaid]

Thanks @gromgit!

[MikeMcQuaid]

This is a little weird but not a blocker; when doesn't it respond to full_name?

[gromgit]

Yup. brew install dump works just fine if I just do cask.full_name, but brew tests kept throwing errors like:

Failures:

  1) Homebrew::Bundle::CaskDumper when casks `foo`, `bar` and `baz` are installed, with `baz` being a formula requirement dumps as `cask 'baz'` and `cask 'foo' cask 'bar'` plus descriptions and config values
     Got 4 failures:

     1.1) Failure/Error: expect(dumper.dump(describe: true)).to eql(expected.chomp)
            #<InstanceDouble(Cask::Cask) (anonymous)> received unexpected message :full_name with (no args)
          # ./bundle/cask_dumper.rb:42:in 'block in Homebrew::Bundle::CaskDumper.dump'
          # ./bundle/cask_dumper.rb:39:in 'Array#map'
          # ./bundle/cask_dumper.rb:39:in 'Homebrew::Bundle::CaskDumper.dump'
          # ./test/bundle/cask_dumper_spec.rb:80:in 'block (3 levels) in <main>'

     1.2) Failure/Error: expect(dumper.dump(describe: true)).to eql(expected.chomp)
            #<InstanceDouble(Cask::Cask) (anonymous)> received unexpected message :full_name with (no args)
          # ./bundle/cask_dumper.rb:42:in 'block in Homebrew::Bundle::CaskDumper.dump'
          # ./bundle/cask_dumper.rb:39:in 'Array#map'
          # ./bundle/cask_dumper.rb:39:in 'Homebrew::Bundle::CaskDumper.dump'
          # ./test/bundle/cask_dumper_spec.rb:80:in 'block (3 levels) in <main>'

     1.3) Failure/Error: expect(dumper.dump(describe: true)).to eql(expected.chomp)
            #<InstanceDouble(Cask::Cask) (anonymous)> received unexpected message :full_name with (no args)
          # ./bundle/cask_dumper.rb:42:in 'block in Homebrew::Bundle::CaskDumper.dump'
          # ./bundle/cask_dumper.rb:39:in 'Array#map'
          # ./bundle/cask_dumper.rb:39:in 'Homebrew::Bundle::CaskDumper.dump'
          # ./test/bundle/cask_dumper_spec.rb:80:in 'block (3 levels) in <main>'

     1.4) Failure/Error: expect(dumper.dump(describe: true)).to eql(expected.chomp)

            expected: "cask \"foo\"\ncask \"bar\", args: { fontdir: \"/Library/Fonts\", language: \"zh-TW\" }\n# Software\ncask \"baz\""
                 got: "cask \"#<RSpec::Expectations::FailureAggregator::AggregatedFailure:0x0000000121e50c00>\"\ncask \"#<RSpec::Expectations::FailureAggregator::AggregatedFailure:0x0000000121e50c00>\", args: { fontdir: \"/Library/Fonts\", language: \"zh-TW\" }\n# Software\ncask \"#<RSpec::Expectations::FailureAggregator::AggregatedFailure:0x0000000121e50c00>\""

            (compared using eql?)

            Diff:

            @@ -1,4 +1,4 @@
            -cask "foo"
            -cask "bar", args: { fontdir: "/Library/Fonts", language: "zh-TW" }
            +cask "#<RSpec::Expectations::FailureAggregator::AggregatedFailure:0x0000000121e50c00>"
            +cask "#<RSpec::Expectations::FailureAggregator::AggregatedFailure:0x0000000121e50c00>", args: { fontdir: "/Library/Fonts", language: "zh-TW" }
             # Software
            -cask "baz"
            +cask "#<RSpec::Expectations::FailureAggregator::AggregatedFailure:0x0000000121e50c00>"

          # ./test/bundle/cask_dumper_spec.rb:80:in 'block (3 levels) in <main>'

I think it's because the test cask objects aren't fully populated like actual cask objects.

[MikeMcQuaid]

@gromgit Thanks! If you can be bothered: ideally populate those test cask double objects in the cask_dumper_spec instead so it always provides a full_name? No worries if not.

[gromgit]

I'll see what I can do.