Allow using dashes (-) in tap names#21414
Merged
MikeMcQuaid merged 2 commits intoHomebrew:mainfrom Jan 17, 2026
Merged
Conversation
MikeMcQuaid
approved these changes
Jan 16, 2026
Member
MikeMcQuaid
left a comment
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Seems reasonable, thanks!
This allows for tap repositories to contain dashes anywhere in name not only in the `homebrew-` prefix. This bring it on par with `TestBot.HOMEBREW_TAP_REGEX` (see https://github.com/Homebrew/brew/blob/110b93e/Library/Homebrew/test_bot.rb#L24) and `Bundle.Dsl.Entry.HOMEBREW_TAP_ARGS_REGEX` (see https://github.com/Homebrew/brew/blob/110b93e/Library/Homebrew/bundle/dsl.rb#L114). I have stumbled upon it when wanted to add my formulae to `runtime_cpu_detection_allowlist.json` in `pkryger/homebrew-emacsmacport-exp` tap, and `brew audit --strict` has been not accepting my exceptions (see https://github.com/orgs/Homebrew/discussions/6656).
p-linnane
force-pushed
the
allow-dashes-in-tap-names
branch
from
9353b65 to
cefe760
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for tap repositories to contain dashes anywhere in name not only in the
homebrew-prefix.This bring it on par with
TestBot.HOMEBREW_TAP_REGEX(see https://github.com/Homebrew/brew/blob/110b93e/Library/Homebrew/test_bot.rb#L24) andBundle.Dsl.Entry.HOMEBREW_TAP_ARGS_REGEX(see https://github.com/Homebrew/brew/blob/110b93e/Library/Homebrew/bundle/dsl.rb#L114).I have stumbled upon it when wanted to add my formulae to
runtime_cpu_detection_allowlist.jsoninpkryger/homebrew-emacsmacport-exptap, andbrew audit --stricthas been not accepting my exceptions (see https://github.com/orgs/Homebrew/discussions/6656).brew lgtm(style, typechecking and tests) with your changes locally?