test/bundle/formula_installer_spec: avoid slow brew link#21203
Merged
MikeMcQuaid merged 1 commit intomainfrom Dec 10, 2025
Merged
test/bundle/formula_installer_spec: avoid slow brew link#21203MikeMcQuaid merged 1 commit intomainfrom
brew link#21203MikeMcQuaid merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves test performance by avoiding slow brew link subprocess calls in tests that don't verify linking behavior. The changes mock Homebrew::Bundle.brew("link", ...) in three test contexts that focus on service management and postinstall behavior, reducing the test file execution time from 58 seconds to 16 seconds.
- Adds mocking to avoid subprocess overhead in non-link-related tests
- Achieves ~72% reduction in test execution time (58s → 16s)
- Follows established testing patterns by using
allowstubs for non-verified behavior
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?We probably should look into improving performance here as
brew bundlecan now directly interact withHomebrew::Cmd::Link. So it should no longer need to create anotherbrewinstance, which requires subshell and then another Ruby adding a noticeable overhead.However, in the mean time, we can avoid running this code for testcases that aren't verifying link behavior providing a significant speed up on one of slowest test files:
Before:
After: