Merged
Conversation
inherited_options feature was originally added to support cascading `option :univeral` back in 793d6de. This is now dead code given `:universal` support was removed.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the inherited_options feature from Homebrew's dependency resolution system. The feature was originally added to support cascading the :universal option from parent formulas to their dependencies, but became dead code after :universal support was removed.
Key changes:
- Removed
inherited_optionsparameter fromDependency#satisfied?andDependency#missing_optionsmethods - Simplified
FormulaInstallerto work with arrays ofDependencyobjects instead of[Dependency, Options]tuples - Removed the
inherited_options_formethod andFormula#require_universal_deps?method
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Library/Homebrew/dependency.rb | Removed inherited_options parameter from satisfied? and missing_options methods |
| Library/Homebrew/test/dependency_spec.rb | Updated test to call satisfied? without the now-removed first parameter |
| Library/Homebrew/formula.rb | Removed unused require_universal_deps? method |
| Library/Homebrew/formula_installer.rb | Simplified dependency handling to work with Dependency arrays instead of [Dependency, Options] tuples; removed inherited_options_for method and related logic |
| Library/Homebrew/install.rb | Updated type signatures and code to work with simplified Dependency arrays |
| Library/Homebrew/cmd/info.rb | Updated satisfied? call to remove the empty array parameter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
p-linnane
approved these changes
Dec 7, 2025
MikeMcQuaid
approved these changes
Dec 7, 2025
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
That's a lot of deleted code, very nice, thanks again @cho-m!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?inherited_options feature was originally added to support cascading
option :univeralback in 793d6de.This is now dead code given
:universalsupport was removed.