Skip to content

utils/github: fix failing test#21034

Merged
ZhongRuoyu merged 1 commit intomainfrom
fix-utils-github-test
Nov 12, 2025
Merged

utils/github: fix failing test#21034
ZhongRuoyu merged 1 commit intomainfrom
fix-utils-github-test

Conversation

@botantony
Copy link
Copy Markdown
Member

@botantony botantony commented Nov 12, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Workflow logs and artifacts for Homebrew/homebrew-core#191680 were removed

Workflow logs and artifacts for Homebrew/homebrew-core#191680 were
removed

Signed-off-by: botantony <antonsm21@gmail.com>
Copilot AI review requested due to automatic review settings November 12, 2025 12:51
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a failing test in the GitHub utilities test suite by updating workflow run IDs and artifact URLs to use currently available data, as the previous test data (workflow run #191680) had its artifacts removed.

  • Updated workflow run ID from "191680" to "252626" in two test cases
  • Updated expected artifact URL to match the new workflow run's artifact ID

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Member

@ZhongRuoyu ZhongRuoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ZhongRuoyu ZhongRuoyu enabled auto-merge November 12, 2025 13:13
@ZhongRuoyu ZhongRuoyu added this pull request to the merge queue Nov 12, 2025
Merged via the queue into main with commit 072255e Nov 12, 2025
43 checks passed
@ZhongRuoyu ZhongRuoyu deleted the fix-utils-github-test branch November 12, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants