[Bugfix] 修复列表中涟漪状态不更新 & 关闭动画后仍有涟漪动画的问题 - #6586
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aba20f90c8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| public void clearRippleImmediately() { | ||
| rippler.releaseRipple(false); |
There was a problem hiding this comment.
Remove already-released ripples when clearing a cell
When a list cell is recycled after the mouse has been released, the normal release path has already polled the ripple from ripplesQueue and left it in getChildren() while its fade-out timeline runs. Calling releaseRipple(false) then polls an empty queue and does nothing, allowing the old ripple and overlay animation to remain visible on the cell's new item; the immediate-clear operation needs to stop and remove in-flight child ripples as well.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
我认为不会有什么问题,只要最终能清除掉就行。禁用动画只是为了更快清除掉,就算有动画也没事。
Fixes #6549 Fixes #6554