Skip to content

[Bugfix] 修复列表中涟漪状态不更新 & 关闭动画后仍有涟漪动画的问题 - #6586

Open
ToobLac wants to merge 4 commits into
HMCL-dev:mainfrom
ToobLac:fix/6549
Open

[Bugfix] 修复列表中涟漪状态不更新 & 关闭动画后仍有涟漪动画的问题#6586
ToobLac wants to merge 4 commits into
HMCL-dev:mainfrom
ToobLac:fix/6549

Conversation

@ToobLac

@ToobLac ToobLac commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Fixes #6549 Fixes #6554

@ToobLac
ToobLac marked this pull request as ready for review August 3, 2026 06:11
@github-actions github-actions Bot added the 40+ label Aug 3, 2026
@github-actions github-actions Bot added 100+ and removed 40+ labels Aug 3, 2026
@ToobLac ToobLac changed the title [Bugfix] 修复 #6549: 有涟漪的 ListCell 复用时未清除涟漪的问题 [Bugfix] 修复涟漪相关问题 Aug 3, 2026
@ToobLac ToobLac changed the title [Bugfix] 修复涟漪相关问题 [Bugfix] 修复列表中涟漪状态不更新 & 关闭动画后仍有涟漪动画的问题 Aug 3, 2026
@Glavo

Glavo commented Aug 4, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: aba20f90c8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread HMCL/src/main/java/com/jfoenix/controls/JFXRippler.java
Comment on lines +287 to +288
public void clearRippleImmediately() {
rippler.releaseRipple(false);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove already-released ripples when clearing a cell

When a list cell is recycled after the mouse has been released, the normal release path has already polled the ripple from ripplesQueue and left it in getChildren() while its fade-out timeline runs. Calling releaseRipple(false) then polls an empty queue and does nothing, allowing the old ripple and overlay animation to remain visible on the cell's new item; the immediate-clear operation needs to stop and remove in-flight child ripples as well.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我认为不会有什么问题,只要最终能清除掉就行。禁用动画只是为了更快清除掉,就算有动画也没事。

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Glavo CC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] 按钮水波纹相关问题 [Bug] 切换实例 Pop 中子项可能因滚动条而丢失焦点

2 participants