Skip to content

chore(functions): update dependencies for upper-firestore#14355

Merged
iennae merged 1 commit into
GoogleCloudPlatform:mainfrom
XrossFox:package-update-protobuf-upper-firestore
Jun 26, 2026
Merged

chore(functions): update dependencies for upper-firestore#14355
iennae merged 1 commit into
GoogleCloudPlatform:mainfrom
XrossFox:package-update-protobuf-upper-firestore

Conversation

@XrossFox

@XrossFox XrossFox commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Description

  • Update protobuf, cloudevents, functions-framework, google-api-core, and google-cloud-firestore to latest versions
  • Remove python version constraint for pytest in requirements-test.txt

Fixes b/527482643

Checklist

Testing

  • I have tested this change on a live environment and verified it works as intended.

Compliance & Style


Post-Approval Actions

  • Please merge this PR for me once it is approved

 - Update `protobuf`, `cloudevents`, `functions-framework`, `google-api-core`, and `google-cloud-firestore` to latest versions
 - Remove python version constraint for pytest in `requirements-test.txt`
@product-auto-label product-auto-label Bot added api: cloudfunctions Issues related to the Cloud Run functions API. samples Issues that are directly related to samples. labels Jun 25, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates and reorders several dependencies in requirements.txt and simplifies the pytest requirement in requirements-test.txt. Feedback was provided regarding a non-existent version specified for the protobuf package (6.33.6), which will cause installation failures, and a correction to a valid version was suggested.

Comment thread functions/v2/firebase/upper-firestore/requirements.txt
@XrossFox

Copy link
Copy Markdown
Contributor Author

I have tested this sample locally and is working:

image

Note: this sample does not have nox.

@angelcaamal angelcaamal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@XrossFox XrossFox marked this pull request as ready for review June 25, 2026 23:43
@XrossFox XrossFox requested review from a team as code owners June 25, 2026 23:43
@iennae iennae merged commit c825c1a into GoogleCloudPlatform:main Jun 26, 2026
10 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: cloudfunctions Issues related to the Cloud Run functions API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants