Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions parametermanager/snippets/get_param_version.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,12 @@


# [START parametermanager_get_param_version]

# The GetParameterVersion operation retrieves parameter metadata and doesn't
# support high-volume access. To access parameter values at scale,
# see Access a parameter version (https://docs.cloud.google.com/secret-manager/parameter-manager/docs/render-parameter-version).


Comment on lines +23 to +28
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The added guidance comment is separated from the function by multiple blank lines, which reduces its clarity and association with the get_param_version function. Additionally, the URL should use the canonical cloud.google.com domain instead of docs.cloud.google.com.

Suggested change
# The GetParameterVersion operation retrieves parameter metadata and doesn't
# support high-volume access. To access parameter values at scale,
# see Access a parameter version (https://docs.cloud.google.com/secret-manager/parameter-manager/docs/render-parameter-version).
# The GetParameterVersion operation retrieves parameter metadata and doesn't
# support high-volume access. To access parameter values at scale,
# see Access a parameter version (https://cloud.google.com/secret-manager/parameter-manager/docs/render-parameter-version).

def get_param_version(
project_id: str, parameter_id: str, version_id: str
) -> parametermanager_v1.ParameterVersion:
Expand Down