Skip to content

fix flaky tests of jobs v4 - #2714

Merged
gcf-merge-on-green[bot] merged 1 commit into
masterfrom
fix-tests-jobs-v4
Apr 21, 2020
Merged

gcf-merge-on-green[bot] merged 1 commit into
masterfrom
fix-tests-jobs-v4

Conversation

@munkhuushmgl

Copy link
Copy Markdown
Contributor

@munkhuushmgl
munkhuushmgl requested a review from a team April 21, 2020 19:49
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 21, 2020
@lesv lesv added the automerge Merge the pull request once unit tests and other checks pass. label Apr 21, 2020
@lesv

lesv commented Apr 21, 2020

Copy link
Copy Markdown
Contributor

Why does changing the JobID fix things?

@munkhuushmgl

Copy link
Copy Markdown
Contributor Author

Why does changing the JobID fix things?

Someone deleted the Job I created for test even though I added DO_NOT_DELETE label on name and id.

@kurtisvg

Copy link
Copy Markdown
Contributor

Can we either create the job as part of the setup, or else hand it in through an env var? That would be compliant with the sample guidelines.

@gcf-merge-on-green
gcf-merge-on-green Bot merged commit c95a52f into master Apr 21, 2020
@gcf-merge-on-green
gcf-merge-on-green Bot deleted the fix-tests-jobs-v4 branch April 21, 2020 20:00
@munkhuushmgl

Copy link
Copy Markdown
Contributor Author

Can we either create the job as part of the setup, or else hand it in through an env var? That would be compliant with the sample guidelines.

@kurtisvg I think having job ID as env var is great idea, and I will make that changes this week. Initially there was setup and teardown for creating and deleting job, but reviewer suggested to have predefined vars to reduce complexity.

@lesv lesv mentioned this pull request Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CommuteSearchJobsTest: testCommuteSearchJobs failed

4 participants