Repository navigation
fix flaky tests of jobs v4 - #2714
Merged
Merged
Conversation
lesv
approved these changes
Apr 21, 2020
Contributor
|
Why does changing the JobID fix things? |
Contributor
Author
Someone deleted the Job I created for test even though I added DO_NOT_DELETE label on name and id. |
Contributor
|
Can we either create the job as part of the setup, or else hand it in through an env var? That would be compliant with the sample guidelines. |
Contributor
Author
@kurtisvg I think having job ID as env var is great idea, and I will make that changes this week. Initially there was setup and teardown for creating and deleting job, but reviewer suggested to have predefined vars to reduce complexity. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2681 #2684 #2682 #2683