Skip to content

Rename FhirResourceGetHistory -> FhirResourceListHistory, implement FhirResourceGetHistory. - #2456

Merged
dzlier-gcp merged 3 commits into
GoogleCloudPlatform:masterfrom
dzlier-gcp:master
Apr 8, 2020
Merged

dzlier-gcp merged 3 commits into
GoogleCloudPlatform:masterfrom
dzlier-gcp:master

Conversation

@dzlier-gcp

Copy link
Copy Markdown
Member

No description provided.

@dzlier-gcp
dzlier-gcp requested a review from a team March 20, 2020 23:06
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 20, 2020
@dzlier-gcp dzlier-gcp added the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 20, 2020

@lesv lesv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider the comments, it's really the client that's poorly done. That said, I'll approve, but wish you'd provide feedback to the client as this is fairly non-idiomatic.

@lesv

lesv commented Apr 3, 2020

Copy link
Copy Markdown
Contributor

@dzlier-gcp What's the status of this API?

@lesv lesv added the api: healthcare Issues related to the Cloud Healthcare API API. label Apr 3, 2020
@lesv

lesv commented Apr 6, 2020

Copy link
Copy Markdown
Contributor

ping

dzlier-gcp added a commit to dzlier-gcp/java-docs-samples that referenced this pull request Apr 6, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 6, 2020
dzlier-gcp added a commit to dzlier-gcp/java-docs-samples that referenced this pull request Apr 8, 2020
dzlier-gcp added a commit to dzlier-gcp/java-docs-samples that referenced this pull request Apr 8, 2020
Comment thread healthcare/v1beta1/pom.xml Outdated
Comment on lines +15 to +16
<source>10</source>
<target>10</target>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be either 8 or 11?

Comment on lines 238 to +241
"[{\"op\": \"add\", \"path\": \"/active\", \"value\": false}]");
FhirResourceGetHistory.fhirResourceGetHistory(fhirResourceName);
// Get versionId from results of fhirResourcePatch.
String versionId;
Matcher idMatcher = Pattern.compile("\"versionId\": \"(.*)\"").matcher(bout.toString());

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for tests, but in samples, I'd prefer we used json objects using Guava's GSON, Jackson, or org.json JAVA-Json

@lesv lesv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to use either Java 8 or Java 11; probably 11 as 8 is having a testing failure.

LGTM once that is done.

@dzlier-gcp

Copy link
Copy Markdown
Member Author

Changed to Java 11, though 8 is still Failing instead of passing without running any tests. And the Build Log is empty.

@dzlier-gcp

Copy link
Copy Markdown
Member Author

Nevermind, build log populated. Invalid target release "11"

@dzlier-gcp

Copy link
Copy Markdown
Member Author

Probably need to update the 1.8 in pom.xml as well.

@lesv

lesv commented Apr 8, 2020

Copy link
Copy Markdown
Contributor

Java 11

  • Looks like the import order is wrong
------------------------------------------------------------
- testing healthcare/v1beta1
------------------------------------------------------------
     [java] JVM args ignored when same JVM is used.
     [java] The following classes needed for analysis were missing:
     [java]   initialize
     [java]   makeConcatWithConstants
[ERROR] Possible information exposure through an error message [snippets.healthcare.datasets.DatasetCreate] At DatasetCreate.java:[line 76] INFORMATION_EXPOSURE_THROUGH_AN_ERROR_MESSAGE
[ERROR] Method snippets.healthcare.datasets.DatasetCreate.datasetCreate(String, String, String) attempts to manually schedule threads by calling method Thread.sleep(long) [snippets.healthcare.datasets.DatasetCreate] At DatasetCreate.java:[line 63] MDM_THREAD_YIELD
[ERROR] Exception is caught when Exception is not thrown in snippets.healthcare.datasets.DatasetCreate.datasetCreate(String, String, String) [snippets.healthcare.datasets.DatasetCreate] At DatasetCreate.java:[line 74] REC_CATCH_EXCEPTION
[ERROR] Format string should use %n rather than \n in snippets.healthcare.datasets.DatasetCreate.datasetCreate(String, String, String) [snippets.healthcare.datasets.DatasetCreate] At DatasetCreate.java:[line 75] VA_FORMAT_STRING_USES_NEWLINE
[ERROR] Possible information exposure through an error message [snippets.healthcare.datasets.DatasetDeIdentify] At DatasetDeIdentify.java:[line 85] INFORMATION_EXPOSURE_THROUGH_AN_ERROR_MESSAGE
[ERROR] Method snippets.healthcare.datasets.DatasetDeIdentify.datasetDeIdentify(String, String) builds a list from one element using Arrays.asList rather than Collections.singletonList [snippets.healthcare.datasets.DatasetDeIdentify] At DatasetDeIdentify.java:[line 56] LUI_USE_SINGLETON_LIST
[ERROR] Method snippets.healthcare.datasets.DatasetDeIdentify.datasetDeIdentify(String, String) attempts to manually schedule threads by calling method Thread.sleep(long) [snippets.healthcare.datasets.DatasetDeIdentify] At DatasetDeIdentify.java:[line 71] MDM_THREAD_YIELD
[ERROR] Exception is caught when Exception is not thrown in snippets.healthcare.datasets.DatasetDeIdentify.datasetDeIdentify(String, String) [snippets.healthcare.datasets.DatasetDeIdentify] At DatasetDeIdentify.java:[line 83] REC_CATCH_EXCEPTION
[ERROR] Format string should use %n rather than \n in snippets.healthcare.datasets.DatasetList.datasetList(String, String) [snippets.healthcare.datasets.DatasetList] At DatasetList.java:[line 71] VA_FORMAT_STRING_USES_NEWLINE
[ERROR] Method snippets.healthcare.datasets.DatasetPatch.datasetPatch(String) appears to call the same method on the same object redundantly [snippets.healthcare.datasets.DatasetPatch] At DatasetPatch.java:[line 55] PRMC_POSSIBLY_REDUNDANT_METHOD_CALLS
[ERROR] Method snippets.healthcare.datasets.DatasetSetIamPolicy.datasetSetIamPolicy(String) builds a list from one element using Arrays.asList rather than Collections.singletonList [snippets.healthcare.datasets.DatasetSetIamPolicy] At DatasetSetIamPolicy.java:[line 53] LUI_USE_SINGLETON_LIST
[ERROR] Method snippets.healthcare.datasets.DatasetSetIamPolicy.datasetSetIamPolicy(String) builds a list from one element using Arrays.asList rather than Collections.singletonList [snippets.healthcare.datasets.DatasetSetIamPolicy] At DatasetSetIamPolicy.java:[line 54] LUI_USE_SINGLETON_LIST
[ERROR] Possible information exposure through an error message [snippets.healthcare.dicom.DicomStoreExport] At DicomStoreExport.java:[line 82] INFORMATION_EXPOSURE_THROUGH_AN_ERROR_MESSAGE
[ERROR] Method snippets.healthcare.dicom.DicomStoreExport.dicomStoreExport(String, String) attempts to manually schedule threads by calling method Thread.sleep(long) [snippets.healthcare.dicom.DicomStoreExport] At DicomStoreExport.java:[line 69] MDM_THREAD_YIELD
[ERROR] Exception is caught when Exception is not thrown in snippets.healthcare.dicom.DicomStoreExport.dicomStoreExport(String, String) [snippets.healthcare.dicom.DicomStoreExport] At DicomStoreExport.java:[line 80] REC_CATCH_EXCEPTION
[ERROR] Possible information exposure through an error message [snippets.healthcare.dicom.DicomStoreImport] At DicomStoreImport.java:[line 83] INFORMATION_EXPOSURE_THROUGH_AN_ERROR_MESSAGE
[ERROR] Method snippets.healthcare.dicom.DicomStoreImport.dicomStoreImport(String, String) attempts to manually schedule threads by calling method Thread.sleep(long) [snippets.healthcare.dicom.DicomStoreImport] At DicomStoreImport.java:[line 70] MDM_THREAD_YIELD
[ERROR] Exception is caught when Exception is not thrown in snippets.healthcare.dicom.DicomStoreImport.dicomStoreImport(String, String) [snippets.healthcare.dicom.DicomStoreImport] At DicomStoreImport.java:[line 81] REC_CATCH_EXCEPTION
[ERROR] Format string should use %n rather than \n in snippets.healthcare.dicom.DicomStoreList.dicomStoreList(String) [snippets.healthcare.dicom.DicomStoreList] At DicomStoreList.java:[line 72] VA_FORMAT_STRING_USES_NEWLINE
[ERROR] Method snippets.healthcare.dicom.DicomStorePatch.patchDicomStore(String, String) appears to call the same method on the same object redundantly [snippets.healthcare.dicom.DicomStorePatch] At DicomStorePatch.java:[line 59] PRMC_POSSIBLY_REDUNDANT_METHOD_CALLS
[ERROR] Method snippets.healthcare.dicom.DicomStoreSetIamPolicy.dicomStoreSetIamPolicy(String) builds a list from one element using Arrays.asList rather than Collections.singletonList [snippets.healthcare.dicom.DicomStoreSetIamPolicy] At DicomStoreSetIamPolicy.java:[line 55] LUI_USE_SINGLETON_LIST
[ERROR] Method snippets.healthcare.dicom.DicomStoreSetIamPolicy.dicomStoreSetIamPolicy(String) builds a list from one element using Arrays.asList rather than Collections.singletonList [snippets.healthcare.dicom.DicomStoreSetIamPolicy] At DicomStoreSetIamPolicy.java:[line 56] LUI_USE_SINGLETON_LIST
[ERROR] Method snippets.healthcare.dicom.DicomWebRetrieveInstance.dicomWebRetrieveInstance(String, String) has abnormal exit from finally block [snippets.healthcare.dicom.DicomWebRetrieveInstance] At DicomWebRetrieveInstance.java:[line 77] AFBR_ABNORMAL_FINALLY_BLOCK_RETURN
[ERROR] Method snippets.healthcare.dicom.DicomWebRetrieveInstance.dicomWebRetrieveInstance(String, String) uses a FileInputStream or FileOutputStream constructor [snippets.healthcare.dicom.DicomWebRetrieveInstance] At DicomWebRetrieveInstance.java:[line 72] IOI_USE_OF_FILE_STREAM_CONSTRUCTORS
[ERROR] Format string should use %n rather than \n in snippets.healthcare.dicom.DicomWebRetrieveInstance.dicomWebRetrieveInstance(String, String) [snippets.healthcare.dicom.DicomWebRetrieveInstance] At DicomWebRetrieveInstance.java:[line 82] VA_FORMAT_STRING_USES_NEWLINE
[ERROR] Method snippets.healthcare.dicom.DicomWebRetrieveRendered.dicomWebRetrieveRendered(String, String) has abnormal exit from finally block [snippets.healthcare.dicom.DicomWebRetrieveRendered] At DicomWebRetrieveRendered.java:[line 77] AFBR_ABNORMAL_FINALLY_BLOCK_RETURN
[ERROR] Method snippets.healthcare.dicom.DicomWebRetrieveRendered.dicomWebRetrieveRendered(String, String) uses a FileInputStream or FileOutputStream constructor [snippets.healthcare.dicom.DicomWebRetrieveRendered] At DicomWebRetrieveRendered.java:[line 72] IOI_USE_OF_FILE_STREAM_CONSTRUCTORS
[ERROR] Format string should use %n rather than \n in snippets.healthcare.dicom.DicomWebRetrieveRendered.dicomWebRetrieveRendered(String, String) [snippets.healthcare.dicom.DicomWebRetrieveRendered] At DicomWebRetrieveRendered.java:[line 82] VA_FORMAT_STRING_USES_NEWLINE
[ERROR] Method snippets.healthcare.dicom.DicomWebRetrieveStudy.dicomWebRetrieveStudy(String, String) has abnormal exit from finally block [snippets.healthcare.dicom.DicomWebRetrieveStudy] At DicomWebRetrieveStudy.java:[line 76] AFBR_ABNORMAL_FINALLY_BLOCK_RETURN
[ERROR] Method snippets.healthcare.dicom.DicomWebRetrieveStudy.dicomWebRetrieveStudy(String, String) uses a FileInputStream or FileOutputStream constructor [snippets.healthcare.dicom.DicomWebRetrieveStudy] At DicomWebRetrieveStudy.java:[line 71] IOI_USE_OF_FILE_STREAM_CONSTRUCTORS
[ERROR] Format string should use %n rather than \n in snippets.healthcare.dicom.DicomWebRetrieveStudy.dicomWebRetrieveStudy(String, String) [snippets.healthcare.dicom.DicomWebRetrieveStudy] At DicomWebRetrieveStudy.java:[line 81] VA_FORMAT_STRING_USES_NEWLINE
[ERROR] Method snippets.healthcare.dicom.DicomWebSearchStudies.dicomWebSearchStudies(String) calls toString() on an instance of a class that hasn't overridden toString() [snippets.healthcare.dicom.DicomWebSearchStudies] At DicomWebSearchStudies.java:[line 58] SPP_NON_USEFUL_TOSTRING
[ERROR] Dead store to f in snippets.healthcare.dicom.DicomWebStoreInstance.dicomWebStoreInstance(String, String) [snippets.healthcare.dicom.DicomWebStoreInstance] At DicomWebStoreInstance.java:[line 64] DLS_DEAD_LOCAL_STORE
[ERROR] This API (java/io/File.<init>(Ljava/lang/String;)V) reads a file whose location might be specified by user input [snippets.healthcare.dicom.DicomWebStoreInstance] At DicomWebStoreInstance.java:[line 64] PATH_TRAVERSAL_IN
[ERROR] This API (java/nio/file/Paths.get(Ljava/lang/String;[Ljava/lang/String;)Ljava/nio/file/Path;) reads a file whose location might be specified by user input [snippets.healthcare.dicom.DicomWebStoreInstance] At DicomWebStoreInstance.java:[line 65] PATH_TRAVERSAL_IN
[ERROR] Format string should use %n rather than \n in snippets.healthcare.dicom.DicomWebStoreInstance.dicomWebStoreInstance(String, String) [snippets.healthcare.dicom.DicomWebStoreInstance] At DicomWebStoreInstance.java:[line 78] VA_FORMAT_STRING_USES_NEWLINE
[ERROR] Format string should use %n rather than \n in snippets.healthcare.fhir.FhirStoreExecuteBundle.fhirStoreExecuteBundle(String, String) [snippets.healthcare.fhir.FhirStoreExecuteBundle] At FhirStoreExecuteBundle.java:[line 73] VA_FORMAT_STRING_USES_NEWLINE
[ERROR] Possible information exposure through an error message [snippets.healthcare.fhir.FhirStoreExport] At FhirStoreExport.java:[line 77] INFORMATION_EXPOSURE_THROUGH_AN_ERROR_MESSAGE
[ERROR] Method snippets.healthcare.fhir.FhirStoreExport.fhirStoreExport(String, String) attempts to manually schedule threads by calling method Thread.sleep(long) [snippets.healthcare.fhir.FhirStoreExport] At FhirStoreExport.java:[line 64] MDM_THREAD_YIELD
[ERROR] Exception is caught when Exception is not thrown in snippets.healthcare.fhir.FhirStoreExport.fhirStoreExport(String, String) [snippets.healthcare.fhir.FhirStoreExport] At FhirStoreExport.java:[line 75] REC_CATCH_EXCEPTION
[ERROR] Possible information exposure through an error message [snippets.healthcare.fhir.FhirStoreImport] At FhirStoreImport.java:[line 81] INFORMATION_EXPOSURE_THROUGH_AN_ERROR_MESSAGE
[ERROR] Method snippets.healthcare.fhir.FhirStoreImport.fhirStoreImport(String, String) attempts to manually schedule threads by calling method Thread.sleep(long) [snippets.healthcare.fhir.FhirStoreImport] At FhirStoreImport.java:[line 68] MDM_THREAD_YIELD
[ERROR] Exception is caught when Exception is not thrown in snippets.healthcare.fhir.FhirStoreImport.fhirStoreImport(String, String) [snippets.healthcare.fhir.FhirStoreImport] At FhirStoreImport.java:[line 79] REC_CATCH_EXCEPTION
[ERROR] Format string should use %n rather than \n in snippets.healthcare.fhir.FhirStoreList.fhirStoreList(String) [snippets.healthcare.fhir.FhirStoreList] At FhirStoreList.java:[line 73] VA_FORMAT_STRING_USES_NEWLINE
[ERROR] Method snippets.healthcare.fhir.FhirStorePatch.fhirStorePatch(String, String) appears to call the same method on the same object redundantly [snippets.healthcare.fhir.FhirStorePatch] At FhirStorePatch.java:[line 60] PRMC_POSSIBLY_REDUNDANT_METHOD_CALLS
[ERROR] Method snippets.healthcare.fhir.FhirStoreSetIamPolicy.fhirStoreSetIamPolicy(String) builds a list from one element using Arrays.asList rather than Collections.singletonList [snippets.healthcare.fhir.FhirStoreSetIamPolicy] At FhirStoreSetIamPolicy.java:[line 55] LUI_USE_SINGLETON_LIST
[ERROR] Method snippets.healthcare.fhir.FhirStoreSetIamPolicy.fhirStoreSetIamPolicy(String) builds a list from one element using Arrays.asList rather than Collections.singletonList [snippets.healthcare.fhir.FhirStoreSetIamPolicy] At FhirStoreSetIamPolicy.java:[line 56] LUI_USE_SINGLETON_LIST
[ERROR] Format string should use %n rather than \n in snippets.healthcare.fhir.resources.FhirResourceConditionalPatch.fhirResourceConditionalPatch(String, String, String, String) [snippets.healthcare.fhir.resources.FhirResourceConditionalPatch] At FhirResourceConditionalPatch.java:[line 81] VA_FORMAT_STRING_USES_NEWLINE
[ERROR] Format string should use %n rather than \n in snippets.healthcare.fhir.resources.FhirResourceConditionalUpdate.fhirResourceConditionalUpdate(String, String, String) [snippets.healthcare.fhir.resources.FhirResourceConditionalUpdate] At FhirResourceConditionalUpdate.java:[line 78] VA_FORMAT_STRING_USES_NEWLINE
[ERROR] Format string should use %n rather than \n in snippets.healthcare.fhir.resources.FhirResourceCreate.fhirResourceCreate(String, String) [snippets.healthcare.fhir.resources.FhirResourceCreate] At FhirResourceCreate.java:[line 75] VA_FORMAT_STRING_USES_NEWLINE
[ERROR] Format string should use %n rather than \n in snippets.healthcare.fhir.resources.FhirResourceDelete.fhirResourceDelete(String) [snippets.healthcare.fhir.resources.FhirResourceDelete] At FhirResourceDelete.java:[line 72] VA_FORMAT_STRING_USES_NEWLINE
[ERROR] Format string should use %n rather than \n in snippets.healthcare.fhir.resources.FhirResourceDeletePurge.fhirResourceDeletePurge(String) [snippets.healthcare.fhir.resources.FhirResourceDeletePurge] At FhirResourceDeletePurge.java:[line 72] VA_FORMAT_STRING_USES_NEWLINE
[ERROR] Format string should use %n rather than \n in snippets.healthcare.fhir.resources.FhirResourceGet.fhirResourceGet(String) [snippets.healthcare.fhir.resources.FhirResourceGet] At FhirResourceGet.java:[line 67] VA_FORMAT_STRING_USES_NEWLINE
[ERROR] Format string should use %n rather than \n in snippets.healthcare.fhir.resources.FhirResourceGetHistory.fhirResourceGetHistory(String, String) [snippets.healthcare.fhir.resources.FhirResourceGetHistory] At FhirResourceGetHistory.java:[line 72] VA_FORMAT_STRING_USES_NEWLINE
[ERROR] Format string should use %n rather than \n in snippets.healthcare.fhir.resources.FhirResourceGetPatientEverything.fhirResourceGetPatientEverything(String) [snippets.healthcare.fhir.resources.FhirResourceGetPatientEverything] At FhirResourceGetPatientEverything.java:[line 71] VA_FORMAT_STRING_USES_NEWLINE
[ERROR] Format string should use %n rather than \n in snippets.healthcare.fhir.resources.FhirResourceListHistory.fhirResourceListHistory(String) [snippets.healthcare.fhir.resources.FhirResourceListHistory] At FhirResourceListHistory.java:[line 72] VA_FORMAT_STRING_USES_NEWLINE
[ERROR] Format string should use %n rather than \n in snippets.healthcare.fhir.resources.FhirResourcePatch.fhirResourcePatch(String, String) [snippets.healthcare.fhir.resources.FhirResourcePatch] At FhirResourcePatch.java:[line 75] VA_FORMAT_STRING_USES_NEWLINE
[ERROR] Format string should use %n rather than \n in snippets.healthcare.fhir.resources.FhirResourceSearch.fhirResourceSearch(String) [snippets.healthcare.fhir.resources.FhirResourceSearch] At FhirResourceSearch.java:[line 72] VA_FORMAT_STRING_USES_NEWLINE
[ERROR] Format string should use %n rather than \n in snippets.healthcare.fhir.resources.FhirResourceSearchPost.fhirResourceSearchPost(String, String) [snippets.healthcare.fhir.resources.FhirResourceSearchPost] At FhirResourceSearchPost.java:[line 76] VA_FORMAT_STRING_USES_NEWLINE
[ERROR] Format string should use %n rather than \n in snippets.healthcare.hl7v2.Hl7v2StoreList.hl7v2StoreList(String) [snippets.healthcare.hl7v2.Hl7v2StoreList] At Hl7v2StoreList.java:[line 72] VA_FORMAT_STRING_USES_NEWLINE
[ERROR] Method snippets.healthcare.hl7v2.Hl7v2StorePatch.patchHl7v2Store(String, String) appears to call the same method on the same object redundantly [snippets.healthcare.hl7v2.Hl7v2StorePatch] At Hl7v2StorePatch.java:[line 60] PRMC_POSSIBLY_REDUNDANT_METHOD_CALLS
[ERROR] Method snippets.healthcare.hl7v2.Hl7v2StoreSetIamPolicy.hl7v2StoreSetIamPolicy(String) builds a list from one element using Arrays.asList rather than Collections.singletonList [snippets.healthcare.hl7v2.Hl7v2StoreSetIamPolicy] At Hl7v2StoreSetIamPolicy.java:[line 55] LUI_USE_SINGLETON_LIST
[ERROR] Method snippets.healthcare.hl7v2.Hl7v2StoreSetIamPolicy.hl7v2StoreSetIamPolicy(String) builds a list from one element using Arrays.asList rather than Collections.singletonList [snippets.healthcare.hl7v2.Hl7v2StoreSetIamPolicy] At Hl7v2StoreSetIamPolicy.java:[line 56] LUI_USE_SINGLETON_LIST
[ERROR] This API (java/nio/file/Paths.get(Ljava/lang/String;[Ljava/lang/String;)Ljava/nio/file/Path;) reads a file whose location might be specified by user input [snippets.healthcare.hl7v2.messages.HL7v2MessageCreate] At HL7v2MessageCreate.java:[line 55] PATH_TRAVERSAL_IN
[ERROR] This API (java/nio/file/Paths.get(Ljava/lang/String;[Ljava/lang/String;)Ljava/nio/file/Path;) reads a file whose location might be specified by user input [snippets.healthcare.hl7v2.messages.HL7v2MessageIngest] At HL7v2MessageIngest.java:[line 55] PATH_TRAVERSAL_IN
[ERROR] Format string should use %n rather than \n in snippets.healthcare.hl7v2.messages.HL7v2MessageList.hl7v2MessageList(String) [snippets.healthcare.hl7v2.messages.HL7v2MessageList] At HL7v2MessageList.java:[line 78] VA_FORMAT_STRING_USES_NEWLINE
[ERROR] Method snippets.healthcare.hl7v2.messages.HL7v2MessagePatch.hl7v2MessagePatch(String) appears to call the same method on the same object redundantly [snippets.healthcare.hl7v2.messages.HL7v2MessagePatch] At HL7v2MessagePatch.java:[line 64] PRMC_POSSIBLY_REDUNDANT_METHOD_CALLS
[ERROR] src/test/java/snippets/healthcare/FhirResourceTests.java:[33] (imports) CustomImportOrder: Extra separation in import group before 'com.google.gson.Gson'
[ERROR] src/test/java/snippets/healthcare/FhirResourceTests.java:[33] (imports) CustomImportOrder: Wrong lexicographical order for 'com.google.gson.Gson' import. Should be before 'java.util.regex.Pattern'.
[ERROR] src/test/java/snippets/healthcare/FhirResourceTests.java:[34] (imports) CustomImportOrder: Wrong lexicographical order for 'com.google.gson.JsonArray' import. Should be before 'java.util.regex.Pattern'.
[ERROR] src/test/java/snippets/healthcare/FhirResourceTests.java:[35] (imports) CustomImportOrder: Wrong lexicographical order for 'com.google.gson.JsonObject' import. Should be before 'java.util.regex.Pattern'.
[ERROR] src/test/java/snippets/healthcare/FhirResourceTests.java:[36] (imports) CustomImportOrder: Wrong lexicographical order for 'com.google.gson.JsonPrimitive' import. Should be before 'java.util.regex.Pattern'.
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1:check (default) on project healthcare-samples: You have 5 Checkstyle violations. -> [Help 1]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: healthcare Issues related to the Cloud Healthcare API API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants