Skip to content

refactor(gae8): Remove unused auth region tag - #10341

Merged
Kef131 merged 2 commits into
mainfrom
refactor(gae8)_remove_unused_auth_regiontag
Aug 28, 2026
Merged

refactor(gae8): Remove unused auth region tag#10341
Kef131 merged 2 commits into
mainfrom
refactor(gae8)_remove_unused_auth_regiontag

Conversation

@Kef131

@Kef131 Kef131 commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes #
b/347351385

Remove auth region tag from Greetins.java file

Checklist

Testing

  • I have tested this change on a live environment and verified it works as intended.
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only

Compliance & Style

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample

Post-Approval Actions

  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label Bot added samples Issues that are directly related to samples. api: appengine Issues related to the App Engine Admin API API. labels Aug 26, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the "// [START auth]" and "// [END auth]" region comments around the "authedGreeting" method in Greetings.java. There are no review comments, and I have no additional feedback to provide.

@Kef131
Kef131 marked this pull request as ready for review August 26, 2026 22:08
@Kef131
Kef131 requested review from a team and yoshi-approver as code owners August 26, 2026 22:08
@snippet-bot

snippet-bot Bot commented Aug 26, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@Kef131 Kef131 assigned Kef131 and unassigned harish-sharma-94 Aug 26, 2026
@Kef131 Kef131 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 27, 2026
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 27, 2026
@Kef131 Kef131 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 27, 2026
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 27, 2026

@XrossFox XrossFox left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kef131
Kef131 merged commit f8f7d01 into main Aug 28, 2026
15 checks passed
@Kef131
Kef131 deleted the refactor(gae8)_remove_unused_auth_regiontag branch August 28, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: appengine Issues related to the App Engine Admin API API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants