Skip to content

cleanup: address review comments#341

Merged
coryan merged 1 commit into
GoogleCloudPlatform:mainfrom
coryan:cleanup-declarative-signature-configuration-pr2.5
Mar 15, 2022
Merged

cleanup: address review comments#341
coryan merged 1 commit into
GoogleCloudPlatform:mainfrom
coryan:cleanup-declarative-signature-configuration-pr2.5

Conversation

@coryan
Copy link
Copy Markdown
Contributor

@coryan coryan commented Mar 15, 2022

This PR addresses review comments after an automatic merge.

The auto-merge trapfeature was fully armed when @devjgm approved #340.

This PR addresses review comments after a automatic merge.
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 15, 2022

Codecov Report

Merging #341 (53259ce) into main (aae4eb9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #341   +/-   ##
=======================================
  Coverage   89.24%   89.24%           
=======================================
  Files          98       98           
  Lines        2733     2733           
=======================================
  Hits         2439     2439           
  Misses        294      294           
Impacted Files Coverage Δ
examples/site/bearer_token/bearer_token.cc 82.14% <ø> (ø)
google/cloud/functions/http_request.h 100.00% <ø> (ø)
google/cloud/functions/http_response.h 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aae4eb9...53259ce. Read the comment docs.

@coryan coryan marked this pull request as ready for review March 15, 2022 20:06
@coryan coryan requested a review from a team as a code owner March 15, 2022 20:06
@coryan coryan enabled auto-merge (squash) March 15, 2022 20:14
@coryan coryan merged commit af5534f into GoogleCloudPlatform:main Mar 15, 2022
@coryan coryan deleted the cleanup-declarative-signature-configuration-pr2.5 branch March 15, 2022 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants