Repository navigation
fix: let an instance's sql-data setting override the --sql-data flag - #2719
Open
anishmehta24 wants to merge 1 commit into
Open
anishmehta24 wants to merge 1 commit into
anishmehta24 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
?sql-data=falseon an instance is parsed intoInstanceConnConfig.SQLDataEnabled, but the proxy checkedinstance is true || --sql-data, so with--sql-dataset globally the instance still connected through SQL Data, got a Postgres port and skipped the cache warmup.private-ipandpscalready let the instance value win over the flag; SQL Data now does the same.Since SQL Data only supports Postgres, this is what you'd use to keep a MySQL instance on a normal connection next to Postgres ones:
Added a port selection case to
TestClientInitializationand a case toTestSQLDataWarmup; both fail on main. Rango test ./internal/proxy ./cmdon Linux (WSL).