Exclude jsonrpyc directory from linting#210
Merged
kevinbackhouse merged 2 commits intoGitHubSecurityLab:mainfrom Apr 8, 2026
Merged
Exclude jsonrpyc directory from linting#210kevinbackhouse merged 2 commits intoGitHubSecurityLab:mainfrom
kevinbackhouse merged 2 commits intoGitHubSecurityLab:mainfrom
Conversation
kevinbackhouse
requested review from
JarLob,
Kwstubbs,
anticomputer,
m-y-mo,
p- and
sylwia-budzynska
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Ruff configuration to avoid linting a vendored/3rd-party directory (jsonrpyc) under the CodeQL MCP server code.
Changes:
- Adds a Ruff exclude entry for
src/seclab_taskflow_agent/mcp_servers/codeql/jsonrpyc/.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Configures Ruff to skip linting the jsonrpyc directory. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s Ruff configuration to exclude a bundled third-party directory (jsonrpyc) from Ruff’s file discovery, preventing lint (and other Ruff operations) from touching vendored code.
Changes:
- Add a Ruff
extend-excludeentry forsrc/seclab_taskflow_agent/mcp_servers/codeql/jsonrpyc/.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Extends Ruff’s exclusion list to skip the jsonrpyc third-party directory. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
p-
approved these changes
Apr 8, 2026
anticomputer
approved these changes
Apr 8, 2026
This was referenced Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This directory contains 3rd party code, so it's better not to change it.