Skip to content

ci: drop the unused keyring path from the release workflow - #127

Merged
mogita merged 1 commit into
mainfrom
ci/release-unused-signing-secrets
Nov 16, 2026
Merged

mogita merged 1 commit into
mainfrom
ci/release-unused-signing-secrets

Conversation

@mogita

@mogita mogita commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Problem

The Maven Central step passes SIGNING_SECRET_KEY_RING_FILE and SONATYPE_STAGING_PROFILE_ID from repo secrets, which have to go after the secret rotation. build.gradle.kts never reads the keyring path, and the staging profile ID is not a credential.

Solution

  • Drop SIGNING_SECRET_KEY_RING_FILE. Signing reads GPG_KEY_CONTENTS in memory.
  • Read SONATYPE_STAGING_PROFILE_ID from a variable. Only the Maven Central step uses it, and that step runs only when publish-targets asks for Central.

How to verify

  1. actionlint .github/workflows/release.yml passes.
  2. After merge, delete the repo secrets SIGNING_SECRET_KEY_RING_FILE and SONATYPE_STAGING_PROFILE_ID.

Note

Low Risk
Release workflow env wiring only; no change to Gradle publish or signing logic.

Overview
The Publish to Maven Central step in release.yml no longer passes SIGNING_SECRET_KEY_RING_FILE (Gradle signs from in-memory GPG_KEY_CONTENTS only) and sources SONATYPE_STAGING_PROFILE_ID from a repository variable instead of a secret, since it is configuration rather than a credential.

Reviewed by Cursor Bugbot for commit f9417a0. Bugbot is set up for automated code reviews on this repo. Configure here.

build.gradle.kts signs from GPG_KEY_CONTENTS in memory and never reads SIGNING_SECRET_KEY_RING_FILE. The Sonatype staging profile ID is an ID, not a credential, so it comes from a variable.
@mogita
mogita merged commit fc5f651 into main Nov 16, 2026
10 checks passed
@mogita
mogita deleted the ci/release-unused-signing-secrets branch November 16, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant