Repository navigation
ci: drop the unused keyring path from the release workflow - #127
Merged
Merged
Conversation
build.gradle.kts signs from GPG_KEY_CONTENTS in memory and never reads SIGNING_SECRET_KEY_RING_FILE. The Sonatype staging profile ID is an ID, not a credential, so it comes from a variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Maven Central step passes
SIGNING_SECRET_KEY_RING_FILEandSONATYPE_STAGING_PROFILE_IDfrom repo secrets, which have to go after the secret rotation.build.gradle.ktsnever reads the keyring path, and the staging profile ID is not a credential.Solution
SIGNING_SECRET_KEY_RING_FILE. Signing readsGPG_KEY_CONTENTSin memory.SONATYPE_STAGING_PROFILE_IDfrom a variable. Only the Maven Central step uses it, and that step runs only whenpublish-targetsasks for Central.How to verify
actionlint .github/workflows/release.ymlpasses.SIGNING_SECRET_KEY_RING_FILEandSONATYPE_STAGING_PROFILE_ID.Note
Low Risk
Release workflow env wiring only; no change to Gradle publish or signing logic.
Overview
The Publish to Maven Central step in
release.ymlno longer passesSIGNING_SECRET_KEY_RING_FILE(Gradle signs from in-memoryGPG_KEY_CONTENTSonly) and sourcesSONATYPE_STAGING_PROFILE_IDfrom a repository variable instead of a secret, since it is configuration rather than a credential.Reviewed by Cursor Bugbot for commit f9417a0. Bugbot is set up for automated code reviews on this repo. Configure here.