feat: allow to customize ChannelListHeader#3234
Merged
Merged
Conversation
📝 WalkthroughWalkthroughAdds an optional ChangesChannelListHeader Context Override
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Size Change: +23 B (0%) Total Size: 798 kB 📦 View Changed
ℹ️ View Unchanged
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/components/ChannelList/ChannelList.tsx (1)
197-201: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAdd test coverage for the new override behavior.
This is the core capability introduced by the PR (customizing/removing
ChannelListHeader), but no test exercises overriding it viaComponentContext/WithComponents. Consider adding a test that provides a custom (or null-rendering)ChannelListHeaderoverride and asserts it replaces the default.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/ChannelList/ChannelList.tsx` around lines 197 - 201, Add a test that exercises the new `ChannelListHeader` override path in `ChannelList`/`useComponentContext` by wrapping with `ComponentContext` or `WithComponents` and providing a custom or null-rendering `ChannelListHeader`. The test should assert that the default header is replaced rather than rendered, and reference the `ChannelList` component plus the `ChannelListHeader` slot so the override behavior is covered end to end.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/components/ChannelList/ChannelList.tsx`:
- Around line 197-201: Add a test that exercises the new `ChannelListHeader`
override path in `ChannelList`/`useComponentContext` by wrapping with
`ComponentContext` or `WithComponents` and providing a custom or null-rendering
`ChannelListHeader`. The test should assert that the default header is replaced
rather than rendered, and reference the `ChannelList` component plus the
`ChannelListHeader` slot so the override behavior is covered end to end.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 8c988271-5747-4824-a36c-a282dff812c5
📒 Files selected for processing (2)
src/components/ChannelList/ChannelList.tsxsrc/context/ComponentContext.tsx
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3234 +/- ##
==========================================
- Coverage 84.23% 84.20% -0.04%
==========================================
Files 485 485
Lines 14873 14874 +1
Branches 4709 4710 +1
==========================================
- Hits 12529 12524 -5
- Misses 2344 2350 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
oliverlaz
approved these changes
Jul 6, 2026
github-actions Bot
pushed a commit
that referenced
this pull request
Jul 6, 2026
## [14.7.0](v14.6.1...v14.7.0) (2026-07-06) ### Features * allow to customize ChannelListHeader ([#3234](#3234)) ([f9752d4](f9752d4))
|
🎉 This PR is included in version 14.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Customer request to allow to remove / override the component.
Summary by CodeRabbit