Repository navigation
fix: limit decompressed webhook payloads to 10 MiB - #108
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
APPSEC-326
Problem
The webhook gunzip helper inflated a gzip body with no size limit before the signature check, so an unsigned request of a few hundred KB could expand to hundreds of MB and exhaust memory on a webhook endpoint.
Solution
Decompression now stops at 10 MiB and raises
StreamChat::Webhook::InvalidWebhookError("payload exceeds ... bytes"). RaiseStreamChat::Webhook.max_payload_bytesif your events are larger. The same helper backs the SQS and SNS decode paths.The webhook helper, its tests and the new
_invalid/oversized_compressionfixture are copied byte for byte from a regeneration at chatv241.7.0(protocolopenapi-v241.7.0). The rest of that regeneration is left for a later release.ChatClient#fork_message_idsis added as an alias offork_message_i_dsinextensions/chat_extensions.rb. A later regeneration renames the generated method tofork_message_ids; the extension then keepsfork_message_i_dsas a deprecated alias, so neither name breaks.How to verify
make test && bundle exec rubocopoversized_compressiontest expects "payload exceeds".BEGIN_COMMIT_OVERRIDE
fix: limit decompressed webhook payloads to 10 MiB, configurable with StreamChat::Webhook.max_payload_bytes
feat: add fork_message_ids, the name a later regeneration gives fork_message_i_ds
END_COMMIT_OVERRIDE