fix src/bdict.cc: dict keys should be sorted before encode

[ttys3]

this may fixup issue: #7

[Frederick888]

Could you please add a space after // and format this file using clang-format? There is already a .clang-format in the project.

[ttys3]

done. force pushed

[Frederick888]

Ah, good spot. I actually didn't know the fact that 'there is only a single valid bencoding' and sorting keys of dictionaries is apparently needed for this.

There is a minor formatting issue which I already pointed out above and it'd be nice if you could fix it and squash the commits. Thanks for the contribution.

[ttys3]

Yes, I didn't encounter any problems until one day , some users of Transmission reported to me that the torrent file downloaded can not be used because the private tracker server responsed with : torrent not registered on the server.

then, I did some investigation and found that it is that the php extension we used which generated the wrong bittorrent file.

this invalid bittorrent file actually can used with other torrent clients like qBittorrent or Deluge, because when calculating the info hash value, both qBittorrent and Deluge will respect the key orders in the torrent file. But Transmission client will always re-sort the keys in order, which caused the problem.
And, as a side effect, finally I found the bug in the php-bencode extension and fixed it.

[ttys3]

test added

[Frederick888]

Thank you. I'll release a new version asap.

[Frederick888]

There you go https://github.com/Frederick888/php-bencode/releases/tag/v1.2.5 :)

[ttys3]

thanks for the work. v1.2.5 look really awesome