Repository navigation
feat: add an option to hide AM/PM in the digital widget - #529
Open
ibrahim-iqbal wants to merge 1 commit into
Open
ibrahim-iqbal wants to merge 1 commit into
ibrahim-iqbal wants to merge 1 commit into
Conversation
Add a "Show AM/PM" switch to the digital widget configuration page, as the issue asks, rather than to the app settings. It is stored with the other widget options and defaults to on, so existing widgets look the same. The switch is hidden when the app uses the 24-hour format, where there is no marker to hide, and the preview on the config page follows it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #138.
Adds a Show AM/PM switch to the digital widget configuration page, as the issue asks (on the widget config page, not in the app settings).
widgetShowAmPm), default on, so existing widgets are unchanged.h:mm aandh:mm; the config page preview follows the switch.Checked
./gradlew :app:detekt :app:lintGplayDebug :app:assembleGplayDebugpass.8:46 AMto8:46.RemoteViews.setCharSequence("setFormat12Hour"), so it is worth one look on a device.