[bexchauveto]

Why

Raised in Slack (Audit Trail v2, Swan demo): a create done inside a smart action via context.datasource.get_collection(...).create is never audited as a create row on the Ruby agent — only the action invocation is.

Root cause: AuditTrail::Capture registered its hooks with the public add_hook, i.e. on the hook layer, which sits above action in the decorators stack. Writes issued from an action's execute go down from the action layer and never cross it.

agent-nodejs already handles this with an internalHook layer below action (decorators-stack.ts, addInternalHook). This PR ports that.

What

• DecoratorsStack: new @internal_hook layer (a HookCollectionDecorator) placed between chart and action.
• CollectionCustomizer#add_internal_hook: same signature as add_hook, registers on that layer.
• AuditTrail::Capture: registers its Before/After Create/Update/Delete hooks with add_internal_hook.
• AUDIT_TRAIL.md: documents that writes from inside an action are audited under the action's correlation key.

Behavioral changes to verify manually

• More create/update/delete rows: writes done inside smart actions through Forest are now audited, under the same correlationKey as the action row.
• Writes emitted by the write decorator (e.g. a create with nested relation data that the write layer splits) now traverse the internal layer too, so they produce one audit row per underlying collection write. Same as Node.
• Hook ordering: audit hooks now run below every public hook, so the audit "before" hooks see data already patched by user add_hook handlers, and a user after-hook raising can no longer drop the audit confirmation.
• Renamed fields (unchanged caveat, same as Node): Capture still reads columns from the top-of-stack schema, while the internal layer sees pre-rename names. A collection with a rename_field customization could record those columns as nil. Out of scope here.

Tests

• collection_customizer_spec: an action creating through context.datasource fires add_internal_hook and not add_hook; a direct create fires both. Verified the first one fails when add_internal_hook is pointed at the public layer.
• Full suites: datasource_customizer 760 examples, agent 1427 examples, 0 failures. Rubocop clean.

🤖 Generated with Claude Code

Note

Add internal hook layer so writes inside smart actions are audited

• Adds an internal HookCollectionDecorator layer in DecoratorsStack#initialize, placed below the smart action decorator, so writes made through Forest inside a smart action traverse it (decorators_stack.rb)
• Adds CollectionCustomizer#add_internal_hook, which mirrors add_hook but registers on the internal layer (collection_customizer.rb)
• Switches create, update, and delete audit handlers in Capture to register via the internal layer, so action-triggered writes are recorded under the action's correlationKey in the audit trail (capture.rb)
• Documents the behavior in AUDIT_TRAIL.md: writes that bypass Forest are only represented by the smart-action row
• Behavioral Change: public hooks (add_hook) no longer fire for writes initiated inside a smart action; only internal hooks run for those, and tests in collection_customizer_spec.rb assert this split

^{Macroscope summarized de9440a.}

[qltysh]

Coverage Impact

This PR will not change total coverage.

Modified Files with Diff Coverage (3)

Rating	File	% Diff	Uncovered Line #s
	...est_admin_datasource_customizer/decorators/decorators_stack.rb	100.0%
	...ib/forest_admin_datasource_customizer/collection_customizer.rb	100.0%
	...rest_admin_agent/lib/forest_admin_agent/audit_trail/capture.rb	100.0%
	Total	100.0%

🚦 See full report on Qlty Cloud »

🛟 Help

• Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

• Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

• File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

  • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

[matthv]

Forest Validator · Review: ✅ clean

When (UTC)	Commit	Step	Result
04/11 10:40	de9440a	Review	✅ clean · run 426-20261104103741-matthv

[matthv]

Approved after /validator run 426-20261104103741-matthv: nothing blocking posted, 0 preferential or code style, 0 suppressed below all.

[forest-bot]

🎉 This PR is included in version 1.48.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀