fix: declare the enum field under the name the wire uses

[Tonours]

fixes PRD-993

What

ForestSchemaField declared enum: string[] | null. The wire sends enums. Renamed the property to the name the payload actually carries, and updated the 38 fixture sites that wrote the old name.

Why

Nothing ever confronted the declared type with the received JSON. ForestHttpApi.getSchema ends in a bare cast (permissions/forest-http-api.ts:74), so a wrong declaration survived indefinitely.

Every producer and sibling type already said enums:

Role	Location	Declaration
agent emits	agent/src/utils/forest-schema/generator-fields.ts:71	enums: [...(column.enumValues ?? [])].sort()
SaaS serializes	private-api/src/serializers/schemas/field.js:9	enums
emit-side type	forestadmin-client/src/schema/types.ts:78,318	enums: null | string[]
consumer type	forestadmin-client/src/types.ts:170	enum ← the outlier

A consumer reading field.enum got undefined, always. The one real reader, agent-bff/src/openapi/collect-unfolding.ts:183, already read field.enums and was typed loosely enough not to complain — so the rename closes a latent hole rather than opening one.

This is not cosmetic. The same class of mismatch already shipped a 500: ForestSchemaAction.fields[].enums is declared string[] while the agent sends null for every dynamic-form action, so [...field.enums] threw a TypeError and every GET /agent/v1/context failed against such an agent. Guarded in #1838.

Scope and safety

Not a breaking change despite touching an exported interface. enum never existed on any payload, so no consumer can have been reading it successfully — undefined before, compile error after, which is the point. Kept as fix: rather than a major.

No runtime behaviour changes. No production src reads .enum on a schema field anywhere in the monorepo; the remaining .enum hits are z.enum (zod) and JSON-Schema keywords.

Note for the reviewer

The fixture renames in agent-bff and mcp-server are load-bearing, not tidying. Without them 11 suites in agent-bff and the mcp-server tool suites fail to compile under ts-jest with TS2561.

Worth knowing why that is easy to miss: agent-bff/tsconfig.json sets "include": ["src/**/*"], so yarn build does not typecheck tests. A root build passes clean while the test suites are red. Only yarn test catches it.

How to test

yarn workspace @forestadmin/forestadmin-client test
yarn workspace @forestadmin/agent-bff test
yarn workspace @forestadmin/mcp-server test

Green on this branch: forestadmin-client 284/284, agent-bff 1084/1084, mcp-server 892/892. Lint 0 errors.

Known limitation

The type-level fix has no test that can fail for it in isolation. forestadmin-client/test/schema/index.test.ts compares a hand-built fixture against itself, so it mirrors the type rather than exercising it. The real regression guard is the agent-bff and mcp-server suites, which do fail to compile when the names disagree.

Follow-ups, deliberately not in this PR

• widen ForestSchemaAction.fields[].enums to string[] | null to match the wire; the Array.isArray guard from feat(agent-bff): serve the agent schema contract on GET /agent/v1/context #1838 stays either way
• check whether openapi/unfolded-paths.ts:367 and openapi/collect-unfolding.ts:183 can drop their accommodations
• before publishing: grep the SaaS front for .enum on a schema field. That cannot be checked from this repo and is still open.

Definition of Done

General

• Write an explicit title for the Pull Request, following Conventional Commits specification
• Test manually the implemented changes
• Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

• Consider the security impact of the changes made

[linear-code]

PRD-993

[qltysh]

Coverage Impact

This PR will not change total coverage.

🚦 See full report on Qlty Cloud »

🛟 Help

• Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

• Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

• File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

  • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.