chore(deps): sync internal @forestadmin version pins to workspace versions - #1772
Merged
Conversation
…sions Successive `chore(release): X [skip ci]` commits bumped several workspace packages without re-pinning their dependents, so a fresh install pulled published copies nested under the dependents. Those nested copies drift from the workspace source and cause cross-package TS type-clashes (e.g. two distinct DataSourceFactory types) — breaking any fresh build. `[skip ci]` releases never re-ran CI, so main went red only on the next real build. Align every exact internal pin to the version already present in the workspace: - datasource-customizer 1.69.3 → 1.70.0 - datasource-toolkit 1.53.1 → 1.54.0 - forestadmin-client 1.40.5 → 1.41.0 - datasource-sql 1.17.10 → 1.17.11 - datasource-mongoose 1.13.4 → 1.14.0 - datasource-sequelize 1.13.8 → 1.13.9 - ai-proxy 1.12.0 → 1.12.1 Pure metadata alignment (the versions already ship in the workspace); every @ForestAdmin dependency now resolves to the workspace, no nested published copy. Verified: full topological build of the affected packages passes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Coverage Impact This PR will not change total coverage. 🚦 See full report on Qlty Cloud »🛟 Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Any fresh build of
mainis currently red at the "Installing & Building" step:Root cause
Successive
chore(release): X [skip ci]commits bumped several workspace packages in their ownpackage.jsonbut did not re-pin the dependents that reference them by exact version. Because the pin (e.g."1.53.1") no longer matches the workspace version (1.54.0), yarn installs a published copy nested under each dependent. Those nested copies drift from the workspace source and cause cross-package TS type-clashes (two distinctDataSourceFactorytypes, missing new API likeisEnumField). Since the releases carry[skip ci], CI never re-ran —main's last green run predates the desync, and it only surfaces on the next real build (e.g. any open PR).Seven workspace packages were desynced:
Fix
Align every exact internal pin to the version already present in the workspace (32 pin edits across 12
package.json+ a 1-lineyarn.lockreconciliation). Pure metadata — no source or behavior change; the target versions already ship in the workspace. After the fix, every@forestadmin/*dependency resolves to the workspace symlink with no nested published copy.Verification
yarn install→ zeropackages/*/node_modules/@forestadmin/*nested copies remain.Unblocks every open PR (they all fail on this same fresh-build error).
🤖 Generated with Claude Code
Note
Sync internal @ForestAdmin dependency version pins to workspace versions
Updates pinned versions of internal
@forestadmin/*packages across all workspacepackage.jsonfiles to match their current workspace versions. Affected packages includedatasource-toolkit,forestadmin-client,datasource-customizer,datasource-sql,datasource-mongoose,datasource-sequelize, andai-proxy. Theyarn.lockis updated accordingly.Macroscope summarized 37054e2.